Disable Zip Decryption auth check. #3151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This default causes zip members to be decompressed into a memory buffer leading to huge memory consumption. In practice the embedded zip file has sufficient structure to be fortified against bit manipulation attacks anyway and there are checksums.
This allows decryption by other tools (e.g. 7zip).
scudette
added a commit
that referenced
this pull request
Dec 13, 2023
This default causes zip members to be decompressed into a memory buffer leading to huge memory consumption. In practice the embedded zip file has sufficient structure to be fortified against bit manipulation attacks anyway and there are checksums. Optionally report the derived session password. This allows decryption by other tools (e.g. 7zip).
scudette
added a commit
that referenced
this pull request
Dec 13, 2023
This default causes zip members to be decompressed into a memory buffer leading to huge memory consumption. In practice the embedded zip file has sufficient structure to be fortified against bit manipulation attacks anyway and there are checksums. Optionally report the derived session password. This allows decryption by other tools (e.g. 7zip).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This default causes zip members to be decompressed into a memory
buffer leading to huge memory consumption.
In practice the embedded zip file has sufficient structure to be
fortified against bit manipulation attacks anyway and there are
checksums.
Optionally report the derived session password. This allows decryption by other tools (e.g. 7zip).