Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added xattr plugin for darwin. #3276

Merged
merged 6 commits into from
Feb 13, 2024
Merged

Conversation

bmcdermott-r7
Copy link
Contributor

Addressing issue #3273

@scudette
Copy link
Contributor

scudette commented Feb 8, 2024

Since code is really taking one value and returning one value it is probably better to do it as a VQL function rather than a plugin. Plugins are good for returning multiple rows but if we use a function it feels more natural to use it. For example instead of

As a plugin

SELECT * FROM foreach(row={ SELECT * FROM glob(....) }.
query={
  SELECT * FROM xattr(filename=OSPath)
})

As a function

SELECT *, xattr(filename=OSPath) AS Xattr FROM glob(...)

@CLAassistant
Copy link

CLAassistant commented Feb 8, 2024

CLA assistant check
All committers have signed the CLA.

vql/darwin/xattr.go Outdated Show resolved Hide resolved
vql/darwin/xattr.go Outdated Show resolved Hide resolved
vql/darwin/xattr.go Show resolved Hide resolved
vql/darwin/xattr.go Outdated Show resolved Hide resolved
vql/darwin/xattr.go Outdated Show resolved Hide resolved
vql/darwin/xattr.go Outdated Show resolved Hide resolved
vql/darwin/xattr.go Outdated Show resolved Hide resolved
vql/darwin/xattr.go Outdated Show resolved Hide resolved
vql/darwin/xattr.go Outdated Show resolved Hide resolved
vql/darwin/xattr_test.go Outdated Show resolved Hide resolved
vql/darwin/xattr_test.go Outdated Show resolved Hide resolved
vql/darwin/xattr_test.go Outdated Show resolved Hide resolved
vql/darwin/xattr_test.go Outdated Show resolved Hide resolved
vql/darwin/xattr_test.go Show resolved Hide resolved
vql/darwin/xattr_test.go Outdated Show resolved Hide resolved
vql/darwin/xattr.go Outdated Show resolved Hide resolved
vql/darwin/xattr.go Outdated Show resolved Hide resolved
vql/darwin/xattr_test.go Outdated Show resolved Hide resolved
vql/darwin/xattr_test.go Outdated Show resolved Hide resolved
vql/darwin/xattr_test.go Outdated Show resolved Hide resolved
vql/darwin/xattr_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please not remove unrelated files? Also please dont change package-lock.json as it is managed by Snyke

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry AV removed it, and I didn't notice in the PR.

@scudette scudette merged commit 7bdbcd6 into Velocidex:master Feb 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants