-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added xattr plugin for darwin. #3276
Conversation
Since code is really taking one value and returning one value it is probably better to do it as a VQL function rather than a plugin. Plugins are good for returning multiple rows but if we use a function it feels more natural to use it. For example instead of As a plugin SELECT * FROM foreach(row={ SELECT * FROM glob(....) }.
query={
SELECT * FROM xattr(filename=OSPath)
}) As a function SELECT *, xattr(filename=OSPath) AS Xattr FROM glob(...) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please not remove unrelated files? Also please dont change package-lock.json as it is managed by Snyke
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry AV removed it, and I didn't notice in the PR.
Addressing issue #3273