Refactor of hunt management #4037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deleting hunts was done serially which made them very slow on slow filesystems. This PR adds a thread pool for deletions. Also many hunt files were not properly deleted: * delete the hunt indexs * delete exports in a hunt * delete hunt notebooks Also added API.max_grpc_recv_size to allow increasing the grpc limit from 4mb if needed (not recommended though).
This was referenced Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deleting hunts was done serially which made them very slow on slow filesystems. This PR adds a thread pool for deletions.
Also many hunt files were not properly deleted:
Also added API.max_grpc_recv_size to allow increasing the grpc limit from 4mb if needed (not recommended though).