Prevent crash in some cases when glob is invalid. #4039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! I think I've been experiencing this lately with certain KAPE artifacts, specifically when leveraging VSS with the KapeTriage Target. I think it was a glob for a web browser artifact that would always cause the offline collector to freeze early on and therefore never complete, but if I targeted non-web browser artifacts like Event Logs, NTFS metadata files, etc, there'd be no issues, even with VSS. |
|
Thanks for reporting that. To be clear the issue was that the glob itself was not valid and add we tried to convert that to a regex there was an error. This pr will prevent the crash but now actually all the globs will be rejected because we now try to compile all the regex before we start. So it's still very important to find the offending glob and fix it because it will now result in an earlier failure and none of the globs will work |
|
Hmmm, I tried again with event logs this morning and it appeared to hang again before actually going through the VSS. Granted, this is an extreme case where this host has over 270 VSCs on it, but I've seen it do similar on hosts with much fewer VSCs. It's 1651 UTC, as I type this, so it has been hanging for 50 minutes now. If you want, I can create a separate issue for this, as it may be a separate issue. Thoughts? |
|
This is unlikely to be related since the original bug was a crash. If you experience a hang out would be interesting to see what's going on You can enable the debug server as it's working and see what's happening inside the binary as described here https://docs.velociraptor.app/docs/deployment/troubleshooting/#debugging-the-offline-collector |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.