Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styles are now correctly displayed when 'inline_sources = TRUE' #22

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Zeioth
Copy link
Contributor

@Zeioth Zeioth commented Jan 15, 2017

The styles were incorrecly displayed in all sections showing source code when said option was enabled. I fixed it replacing the next line in doxy-boot.js

$( document ).ready(function() { /* code */ });

by

window.setTimeout(function() { /* code */ }));

Also I clarified the readme for an easier installation process. Tested and working.

@Zeioth Zeioth force-pushed the master branch 5 times, most recently from 9dcbc94 to 0de8070 Compare January 15, 2017 23:15
@Zeioth Zeioth mentioned this pull request Jan 15, 2017
@Zeioth Zeioth force-pushed the master branch 3 times, most recently from 67684fb to 6f05442 Compare January 16, 2017 02:38
@Zeioth
Copy link
Contributor Author

Zeioth commented Jan 16, 2017

Ok, ready to merge.

@Zeioth Zeioth changed the title Fixed bugs of navbar in inner sections Styles are now correctly displayed when 'inline_sources = TRUE' Jan 16, 2017
@ghost
Copy link

ghost commented Jan 29, 2017

I tested your commits in my projects' docs, and your main – window.setTimeout – is causing a "flicker" when the style is transitioning from – without Bootstrap – to the new visual – with Bootstrap.
Despite this is a valuable contribution, I believe this "flickering" behavior is undesirable, as it is very unconfortable for the final user.

@Zeioth
Copy link
Contributor Author

Zeioth commented Jan 29, 2017

You are right. The fix works perfectly on Firefox, but doesn't work at all in Chrome. I'll look for a better solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant