Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(plugin): ExtraConnectionLinks #2642

Open
wants to merge 9 commits into
base: dev
Choose a base branch
from
Open

feat(plugin): ExtraConnectionLinks #2642

wants to merge 9 commits into from
+77 −0

Conversation

coopeeo
Copy link

@coopeeo coopeeo commented Jun 30, 2024 •
edited
Loading

This plugin adds an open profile button for connections that don't have it in the native Discord client.

@coopeeo coopeeo mentioned this pull request Jun 30, 2024
Open
4 tasks
Sqaaakoi
Sqaaakoi reviewed Jun 30, 2024
View reviewed changes
Copy link
Contributor

@Sqaaakoi Sqaaakoi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should patch where these connections are fetched from, if possible. This would make the plugin work with ShowConnections without having to edit it directly

src/plugins/openMoreConnections/index.ts Outdated Show resolved Hide resolved
src/plugins/showConnections/index.tsx Outdated Show resolved Hide resolved
@Scyye
Copy link
Contributor

Scyye commented Jun 30, 2024

I think the name could be improved on. not sure how, but "OpenMoreConnections" doesnt easily imply what it does.

@verticalsync
Copy link
Contributor

verticalsync commented Jun 30, 2024 •
edited
Loading

I think the name could be improved on. not sure how, but "OpenMoreConnections" doesnt easily imply what it does.

what about something like ExtraConnectionLinks.

@coopeeo
Copy link
Author

coopeeo commented Jun 30, 2024

I think the name could be improved on. not sure how, but "OpenMoreConnections" doesnt easily imply what it does.

i agree i just couldn't come up with something else

@coopeeo
Copy link
Author

coopeeo commented Jun 30, 2024

I think the name could be improved on. not sure how, but "OpenMoreConnections" doesnt easily imply what it does.

what about something like ExtraConnectionLinks.

sure that is a good one

@coopeeo coopeeo changed the title feat(plugin): OpenMoreConnections feat(plugin): ExtraConnectionLinks Jul 2, 2024
@coopeeo
Copy link
Author

coopeeo commented Jul 4, 2024

reminder to self (because i don't feel like doing this rn) remember to update description to: "Allows you to open more connections in browser!"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sqaaakoi Sqaaakoi Sqaaakoi left review comments

@nin0-dev nin0-dev nin0-dev left review comments

@schoeneBiene schoeneBiene schoeneBiene left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@coopeeo @Scyye @verticalsync @Sqaaakoi @nin0-dev @schoeneBiene @Vendicated