Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VEN-1830]: Refactor constants and deployment scripts for the sepolia deployment #294

Merged
merged 52 commits into from
Nov 30, 2023
Merged

[VEN-1830]: Refactor constants and deployment scripts for the sepolia deployment #294

merged 52 commits into from
Nov 30, 2023

Conversation

0xlucian
Copy link
Contributor

Description

This PR refactors a bit contracts that containg chain specific contants and configures deployment script by adding sepolia and ethereum networks

Resolves #VEN-1830

Checklist

  • I have updated the documentation to account for the changes in the code.
  • If I added new functionality, I added tests covering it.
  • If I fixed a bug, I added a test preventing this bug from silently reappearing again.
  • My contribution follows Venus contribution guidelines.

@chechu chechu changed the title Refactor/ven 1830 [VEN-1830]: Refactor constants and deployment scripts for the sepolia deployment Aug 23, 2023
@0xlucian 0xlucian marked this pull request as ready for review August 28, 2023 14:42
chechu
chechu reviewed Aug 31, 2023
View reviewed changes
contracts/BaseJumpRateModelV2.sol Outdated Show resolved Hide resolved
hardhat.config.ts Outdated Show resolved Hide resolved
helpers/deploymentConfig.ts Show resolved Hide resolved
GitGuru7
GitGuru7 reviewed Sep 6, 2023
View reviewed changes
hardhat.config.ts Show resolved Hide resolved
helpers/deploymentConfig.ts Outdated Show resolved Hide resolved
chechu
chechu reviewed Sep 13, 2023
View reviewed changes
helpers/deploymentConfig.ts Outdated Show resolved Hide resolved
chechu
chechu reviewed Sep 13, 2023
View reviewed changes
helpers/deploymentConfig.ts Outdated Show resolved Hide resolved
Debugger022
Debugger022 previously approved these changes Oct 10, 2023
View reviewed changes
chechu
chechu reviewed Oct 10, 2023
View reviewed changes
helpers/deploymentConfig.ts Outdated Show resolved Hide resolved
helpers/deploymentConfig.ts Outdated Show resolved Hide resolved
helpers/deploymentConfig.ts Outdated Show resolved Hide resolved
helpers/deploymentConfig.ts Outdated Show resolved Hide resolved
chechu
chechu reviewed Oct 11, 2023
View reviewed changes
helpers/deploymentConfig.ts Outdated Show resolved Hide resolved
chechu
chechu reviewed Nov 23, 2023
View reviewed changes
helpers/deploymentConfig.ts Outdated Show resolved Hide resolved
chechu
chechu reviewed Nov 23, 2023
View reviewed changes
helpers/deploymentConfig.ts Outdated Show resolved Hide resolved
chechu
chechu reviewed Nov 23, 2023
View reviewed changes
helpers/deploymentConfig.ts Outdated Show resolved Hide resolved
chechu
chechu reviewed Nov 23, 2023
View reviewed changes
helpers/deploymentConfig.ts Outdated Show resolved Hide resolved
0xlucian and others added 13 commits November 28, 2023 10:45
@0xlucian
chore: add deployments in hardhat config file
2af5264
@0xlucian
chore: update package version of oracle
4ed9d5b
@0xlucian
refactor: use Multisig values from deployment config
68b1e8c
@0xlucian
chore: add newly deployed contracts
207c11b
@0xlucian
refactor: VIP based config and scripts to match the latest deployment…
1ccdfbe 
… flow
@0xlucian
refactor: adjust name of imported deployment script
4da3b52
@0xlucian
refactor:add unified config for ethereum and other networks and chang…
afaeec8 
…e .enb.example according to the related changes
@0xlucian @github-actions
feat: updating deployment files
f1e3083
@0xlucian
fix: yarn build
8234296
@0xlucian
Merge branch 'refactor/ven-1830' of github.com:VenusProtocol/isolated…
06aad44 
…-pools into refactor/ven-1830
@0xlucian
chore: update protocol-reserves version
dbb2ce3
@0xlucian
fix: update venus-protocol version
46e1327
@coreyar
fix: bump protocol package version
7bad19c
@github-actions GitHub Actions
Copy link

Code Coverage

Package Line Rate Branch Rate Health
contracts 96% 78% ✔
contracts.Lens 95% 65% ✔
contracts.Pool 100% 92% ✔
contracts.Rewards 95% 62% ✔
contracts.RiskFund 89% 61% ✔
contracts.Shortfall 100% 85% ✔
contracts.lib 100% 89% ✔
Summary 96% (1451 / 1513) 75% (449 / 602) ✔

@chechu chechu requested a review from coreyar November 29, 2023 15:50
@0xlucian 0xlucian merged commit 28b49d7 into develop Nov 30, 2023
4 checks passed
@chechu chechu mentioned this pull request Dec 27, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coreyar coreyar coreyar left review comments

@chechu chechu chechu approved these changes

@web3rover web3rover Awaiting requested review from web3rover

@Debugger022 Debugger022 Awaiting requested review from Debugger022

@GitGuru7 GitGuru7 Awaiting requested review from GitGuru7

Assignees

@0xlucian 0xlucian

Labels
multichain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@0xlucian @chechu @coreyar @Debugger022 @GitGuru7