Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VEN-1930]: forced liquidation #305

Merged
merged 6 commits into from
Oct 18, 2023
Merged

[VEN-1930]: forced liquidation #305

merged 6 commits into from
Oct 18, 2023

Conversation

Debugger022
Copy link
Collaborator

Description

Resolves #

  • VEN-1930

Checklist

  • I have updated the documentation to account for the changes in the code.
  • If I added new functionality, I added tests covering it.
  • If I fixed a bug, I added a test preventing this bug from silently reappearing again.
  • My contribution follows Venus contribution guidelines.

@Debugger022 Debugger022 self-assigned this Sep 13, 2023
@chechu chechu changed the title feat: ven-1930 force liquidation [VEN-1930]: forced liquidation Sep 13, 2023
chechu
chechu reviewed Sep 13, 2023
View reviewed changes
contracts/Comptroller.sol Outdated Show resolved Hide resolved
kkirka
kkirka reviewed Sep 14, 2023
View reviewed changes
Copy link
Collaborator

@kkirka kkirka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I second the request to remove isDeprecated check

contracts/ComptrollerStorage.sol Outdated Show resolved Hide resolved
tests/hardhat/Comptroller/liquidateAccountTest.ts Outdated Show resolved Hide resolved
@Debugger022 Debugger022 requested a review from kkirka October 12, 2023 08:54
chechu
chechu previously approved these changes Oct 13, 2023
View reviewed changes
@Debugger022
Merge pull request #312 from VenusProtocol/VEN-2047
0973a15 
[VEN-2047]: Certik audit fix for forced liquidation
@github-actions
Copy link

Code Coverage

Package Line Rate Branch Rate Health
contracts 96% 78% ✔
contracts.Lens 95% 65% ✔
contracts.Pool 100% 92% ✔
contracts.Rewards 95% 62% ✔
contracts.RiskFund 99% 71% ✔
contracts.Shortfall 100% 85% ✔
contracts.lib 100% 89% ✔
Summary 97% (1462 / 1509) 76% (448 / 592) ✔

@chechu chechu mentioned this pull request Oct 18, 2023
Merged
4 tasks
@chechu chechu merged commit 66d1ea6 into develop Oct 18, 2023
3 checks passed
@kkirka kkirka deleted the VEN-1930 branch November 29, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chechu chechu chechu approved these changes

@web3rover web3rover Awaiting requested review from web3rover

@0xlucian 0xlucian Awaiting requested review from 0xlucian

@kkirka kkirka Awaiting requested review from kkirka

Assignees

@Debugger022 Debugger022

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Debugger022 @chechu @kkirka