[VEN-1430]: Remove legacy scripts and files inherited from Compound #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: We've inherited a scenario test suite from Compound that was useful in initial phases of development. However, these tests are hard to maintain due to outdated toolset and a custom DSL used in these tests. Scenario tests were not maintained, a separate set of integration tests were implemented instead. There is no reason to keep this folder in the repo. Solution: Remove scenario tests.
* Governance simulations in Venus are done via a separate simulations framework located at https://github.com/VenusProtocol/vips * This commit removes legacy Compound simulations in favor of using the new framework
* Certora ruleset has not been maintained for Venus IL, so some of the invariants may no longer hold. The interface of Venus IL contracts is also not always compatible with Compound. * This commit removes outdated Certora rules in favor of using a new ruleset in future once it's developed.
|
kkirka
changed the title
chechu
approved these changes
Sep 26, 2023
0xlucian
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes scripts, scenarios and files related to tooling used by Compound. These files have not been maintained since we focused on modern tooling (hardhat, fork tests, smock) instead of saddle-based ones.
See commit messages for details.