Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VEN-1430]: Remove legacy scripts and files inherited from Compound #307

Merged
merged 4 commits into from
Oct 10, 2023

Conversation

kkirka
Copy link
Collaborator

@kkirka kkirka commented Sep 25, 2023

This PR removes scripts, scenarios and files related to tooling used by Compound. These files have not been maintained since we focused on modern tooling (hardhat, fork tests, smock) instead of saddle-based ones.

See commit messages for details.

Problem: We've inherited a scenario test suite from Compound that
was useful in initial phases of development. However, these tests
are hard to maintain due to outdated toolset and a custom DSL used
in these tests. Scenario tests were not maintained, a separate set
of integration tests were implemented instead. There is no reason
to keep this folder in the repo.

Solution: Remove scenario tests.
* Governance simulations in Venus are done via a separate simulations
framework located at https://github.com/VenusProtocol/vips
* This commit removes legacy Compound simulations in favor of using
the new framework
* Certora ruleset has not been maintained for Venus IL, so some of
the invariants may no longer hold. The interface of Venus IL
contracts is also not always compatible with Compound.
* This commit removes outdated Certora rules in favor of using a
new ruleset in future once it's developed.
@github-actions
Copy link

Code Coverage

Package Line Rate Branch Rate Health
contracts 96% 76%
contracts.Lens 95% 65%
contracts.Pool 100% 92%
contracts.Rewards 95% 62%
contracts.RiskFund 99% 71%
contracts.Shortfall 100% 85%
contracts.lib 100% 89%
Summary 97% (1454 / 1504) 75% (442 / 590)

@kkirka kkirka changed the title VEN-1430: Remove legacy scripts and files inherited from Compound [VEN-1430]: Remove legacy scripts and files inherited from Compound Sep 25, 2023
@kkirka kkirka merged commit 89bc764 into develop Oct 10, 2023
@kkirka kkirka deleted the refactor/cleanup branch October 10, 2023 20:37
@chechu chechu mentioned this pull request Oct 18, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants