Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VEN-2038]: support Core Pool fund in the RiskFund #310

Merged
merged 10 commits into from
Oct 18, 2023
Merged

[VEN-2038]: support Core Pool fund in the RiskFund #310

merged 10 commits into from
Oct 18, 2023

Conversation

web3rover
Copy link
Collaborator

Description

Resolves #

Checklist

  • I have updated the documentation to account for the changes in the code.
  • If I added new functionality, I added tests covering it.
  • If I fixed a bug, I added a test preventing this bug from silently reappearing again.
  • My contribution follows Venus contribution guidelines.

@chechu chechu changed the title Support Core Pool in Comptroller [VEN-2038]: support Core Pool in Comptroller Oct 9, 2023
chechu
chechu reviewed Oct 9, 2023
View reviewed changes
tests/integration/index.ts Outdated Show resolved Hide resolved
Debugger022
Debugger022 previously approved these changes Oct 9, 2023
View reviewed changes
Copy link
Collaborator

@Debugger022 Debugger022 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just need to change the import of the entire file to their interfaces.

The storage layout of RiskFund-V1 is acceptable and can be upgraded in RiskFund-V2. No collisions are observed.

@chechu chechu changed the title [VEN-2038]: support Core Pool in Comptroller [VEN-2038]: support Core Pool fund in the RiskFund Oct 10, 2023
chechu
chechu reviewed Oct 10, 2023
View reviewed changes
tests/integration/index.ts Outdated Show resolved Hide resolved
chechu
chechu previously approved these changes Oct 11, 2023
View reviewed changes
@github-actions
Copy link

Code Coverage

Package Line Rate Branch Rate Health
contracts 96% 76% ✔
contracts.Lens 95% 65% ✔
contracts.Pool 100% 92% ✔
contracts.Rewards 95% 62% ✔
contracts.RiskFund 96% 67% ✔
contracts.Shortfall 100% 85% ✔
contracts.lib 100% 89% ✔
Summary 96% (1462 / 1518) 74% (443 / 596) ✔

@web3rover web3rover requested a review from chechu October 18, 2023 17:30
@web3rover web3rover merged commit 8ed9929 into develop Oct 18, 2023
3 checks passed
@web3rover web3rover deleted the feat/risk-find-core-support branch October 18, 2023 17:31
@chechu chechu mentioned this pull request Oct 18, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Debugger022 Debugger022 Debugger022 left review comments

@chechu chechu Awaiting requested review from chechu

Assignees

@web3rover web3rover

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@web3rover @chechu @Debugger022