Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VEN-2330]: Deployment script for VAIController #354

Draft
wants to merge 1 commit into
base: VEN-2329
Choose a base branch
from

Conversation

Debugger022
Copy link
Collaborator

@Debugger022 Debugger022 commented Jan 24, 2024

Description

Resolves #VEN-2330
This PR includes deployment script for VAIController via Beacon Proxy.

Checklist

  • I have updated the documentation to account for the changes in the code.
  • If I added new functionality, I added tests covering it.
  • If I fixed a bug, I added a test preventing this bug from silently reappearing again.
  • My contribution follows Venus contribution guidelines.

Copy link
Collaborator

@kkirka kkirka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

);

// VAIController Beacon
const vaiControllerImp: DeployResult = await deploy("VAIControllerImp", {
Copy link
Collaborator

@kkirka kkirka Jan 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: We use Impl for Comptroller and VToken, maybe we could do the same here for consistency

Suggested change
const vaiControllerImp: DeployResult = await deploy("VAIControllerImp", {
const vaiControllerImp: DeployResult = await deploy("VAIControllerImpl", {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants