Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VEN-2902] Add EIGEN Market #449

Merged
merged 5 commits into from
Nov 7, 2024
Merged

[VEN-2902] Add EIGEN Market #449

merged 5 commits into from
Nov 7, 2024

Conversation

web3rover
Copy link
Collaborator

Description

Resolves #

Checklist

  • I have updated the documentation to account for the changes in the code.
  • If I added new functionality, I added tests covering it.
  • If I fixed a bug, I added a test preventing this bug from silently reappearing again.
  • My contribution follows Venus contribution guidelines.

@web3rover web3rover requested review from chechu and kkirka October 28, 2024 09:27
@web3rover web3rover self-assigned this Oct 28, 2024
chechu
chechu reviewed Oct 28, 2024
View reviewed changes
helpers/deploymentConfig.ts Outdated Show resolved Hide resolved
chechu
chechu previously approved these changes Oct 28, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link

Code Coverage

Package Line Rate Branch Rate Health
contracts 94% 76% ✔
contracts.Gateway 98% 68% ✔
contracts.Gateway.Interfaces 100% 100% ✔
contracts.Lens 95% 71% ✔
contracts.Lens.legacy 0% 0% ❌
contracts.Pool 100% 92% ✔
contracts.Rewards 96% 70% ✔
contracts.Shortfall 100% 85% ✔
contracts.legacy.RiskFund 0% 0% ❌
contracts.lib 100% 89% ✔
Summary 76% (1557 / 2055) 65% (516 / 798) ➖

kkirka
kkirka approved these changes Nov 7, 2024
View reviewed changes
Copy link
Collaborator

@kkirka kkirka left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deployments LGTM

@web3rover web3rover merged commit a1b1aa8 into develop Nov 7, 2024
4 checks passed
@web3rover web3rover deleted the feat/ven-2902 branch November 7, 2024 17:57
@chechu chechu mentioned this pull request Dec 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GitGuru7 GitGuru7 GitGuru7 approved these changes

@kkirka kkirka kkirka approved these changes

@chechu chechu chechu approved these changes

Assignees

@web3rover web3rover

Labels
ethereum sepolia
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@web3rover @chechu @kkirka @GitGuru7