Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add modifier for min income to make conversions easier on ethereum #68

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

coreyar
Copy link
Contributor

@coreyar coreyar commented Dec 5, 2024

Add an option to modify the min income to allow for more slippage when making conversions

@coreyar coreyar requested review from chechu and kkirka December 5, 2024 16:26
@coreyar coreyar force-pushed the add-min-income-modifier branch from 22eeeda to 4772cb4 Compare December 5, 2024 16:33
@coreyar coreyar force-pushed the add-min-income-modifier branch from 4772cb4 to bb9e4cb Compare December 16, 2024 14:24
@coreyar coreyar force-pushed the add-min-income-modifier branch from bb9e4cb to 9cacb77 Compare December 16, 2024 14:37
description: "Min income in basis points as percentage of amount",
alias: "bp",
description:
"Increase the min income offered to make swaps more likely to succeed. If min income is negative this will increase the amount offered in the swap. If the min the min income is positive this will accept a lower profit.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"Increase the min income offered to make swaps more likely to succeed. If min income is negative this will increase the amount offered in the swap. If the min the min income is positive this will accept a lower profit.",
"Increase the min income offered to make swaps more likely to succeed. If min income is negative this will increase the amount offered in the swap. If the min income is positive this will accept a lower profit.",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants