Merge pull request #148 from VenusProtocol/fix/VEN-2252

[VEN-2252]: Certik audit fix on Binance Oracle
VenusProtocol · Dec 15, 2023 · 9243025 · 9243025
2 parents f13e3af + 4426cd6
commit 9243025
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/contracts/oracles/BinanceOracle.sol b/contracts/oracles/BinanceOracle.sol
@@ -99,9 +99,8 @@ contract BinanceOracle is AccessControlledV8, OracleInterface {
         address newfeedRegistryAddress
     ) external notNullAddress(newfeedRegistryAddress) onlyOwner {
         if (sidRegistryAddress != address(0)) revert("sidRegistryAddress must be zero");
-        address oldFeedRegistry = feedRegistryAddress;
+        emit FeedRegistryUpdated(feedRegistryAddress, newfeedRegistryAddress);
         feedRegistryAddress = newfeedRegistryAddress;
-        emit FeedRegistryUpdated(oldFeedRegistry, newfeedRegistryAddress);
     }
 
     /**

diff --git a/hardhat.config.ts b/hardhat.config.ts
@@ -189,7 +189,7 @@ const config: HardhatUserConfig = {
         network: "opbnbmainnet",
         chainId: 204,
         urls: {
-          apiURL: `https://open-platform.nodereal.io/${process.env.ETHERSCAN_API_KEY}/op-bnb-testnet/contract/`,
+          apiURL: `https://open-platform.nodereal.io/${process.env.ETHERSCAN_API_KEY}/op-bnb-mainnet/contract/`,
           browserURL: "https://opbnbscan.com/",
         },
       },