Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VEN-1829]: Deploy Oracles on Sepolia #124

Merged
merged 45 commits into from
Nov 24, 2023
Merged

[VEN-1829]: Deploy Oracles on Sepolia #124

merged 45 commits into from
Nov 24, 2023

Conversation

0xlucian
Copy link
Contributor

@0xlucian 0xlucian commented Sep 4, 2023

Description

This PR deploys oracles on Sepolia network and introduces the following changes/additions:

  1. Refactor oracle logic for vBNB and native pools support for the oracle
  2. Adds deployment config for Sepolia network
  3. Adds a VIP based config script, that will print the required VIP targets and calldatas to be executed.

Resolves #VEN-1829

Checklist

  • I have updated the documentation to account for the changes in the code.
  • If I added new functionality, I added tests covering it.
  • If I fixed a bug, I added a test preventing this bug from silently reappearing again.
  • My contribution follows Venus contribution guidelines.

contracts/oracles/ChainlinkOracle.sol Outdated Show resolved Hide resolved
contracts/oracles/ChainlinkOracle.sol Outdated Show resolved Hide resolved
deploy/1-deploy-oracles.ts Outdated Show resolved Hide resolved
deploy/2-configure-feeds.ts Outdated Show resolved Hide resolved
deploy/3-vip-based-configuration.ts Outdated Show resolved Hide resolved
contracts/ResilientOracle.sol Show resolved Hide resolved
contracts/ResilientOracle.sol Outdated Show resolved Hide resolved
helpers/deploymentConfig.ts Outdated Show resolved Hide resolved
helpers/deploymentConfig.ts Outdated Show resolved Hide resolved
@0xlucian 0xlucian marked this pull request as ready for review October 11, 2023 10:28
Copy link
Member

@chechu chechu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After merging #133, we have to add to the ci.yml file the following commands in the export-deployments task:

yarn hardhat export --network sepolia --export ./deployments/sepolia.json
yarn hardhat export --network ethereum --export ./deployments/ethereum.json

@chechu chechu changed the title Deploy Oracles on Sepolia [VEN-1829]: Deploy Oracles on Sepolia Nov 22, 2023
0xlucian and others added 25 commits November 24, 2023 15:10
Co-authored-by: Jesus Lanchas <[email protected]>
Co-authored-by: Debugger022 <[email protected]>
Signed-off-by: 0xlucian <[email protected]>
…pport for redstone oracle in deploymentConfig along with adding config for XVS price feed
…in with correct timelock (multisig) for sepolia
Copy link

Code Coverage

Package Line Rate Branch Rate Health
contracts 85% 80%
contracts.interfaces 28% 21%
contracts.libraries 100% 75%
contracts.oracles 97% 83%
Summary 89% (295 / 332) 78% (160 / 206)

@0xlucian 0xlucian merged commit 1b2ac3c into develop Nov 24, 2023
4 checks passed
@chechu chechu mentioned this pull request Dec 27, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants