-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VEN-1895] Add Arbitrum sequencer downtime validation for Chainlink Oracle #128
Conversation
581556f
to
6ff9de3
Compare
6ff9de3
to
5e2dcbf
Compare
@0xlucian Instead of creating a separate contract I think we can add a Also sequencer is used in OP, ARB and Base networks. So if we decide to use a separate contract, then we should rename the contract from |
I would rename the contract to |
@chechu @Narayanprusty I think that having different oracle that extends this functionality makes more sense.. On one side it will save us gas on Ethereum (because we will not have this logic at all) and on the other side I think having non-zero address logic is kinda prone to more errors. |
I prefer |
@chechu @Narayanprusty |
302dda9
to
9fae6ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall
Co-authored-by: Kirill Kuvshinov <[email protected]> Signed-off-by: 0xlucian <[email protected]>
Description
This PR adds Chainlink Oracle support for Arbitrum.
Resolves #VEN-1895
Checklist