Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VEN-2723]: Deployments of Oracles on OpSepolia #204

Merged
merged 7 commits into from
Sep 12, 2024
Merged

[VEN-2723]: Deployments of Oracles on OpSepolia #204

merged 7 commits into from
Sep 12, 2024

Conversation

Debugger022
Copy link
Contributor

@Debugger022 Debugger022 commented Jul 5, 2024 •
edited
Loading

Description

Resolves #

This PR contains the deployments of Oracles on OpSepolia along with the config for OpSepolia and OpMainnet.

Deployed Addresses:
    "BoundValidator": "0x482469F1DA6Ec736cacF6361Ec41621f811A6800",
    "ChainlinkOracle_Proxy": "0x493C3f543AEa37EefF17D823f27Cb1feAB9f3143",
    "DefaultProxyAdmin": "0xa9aaf2A1cCf2C3a87997942abaA740887cC89241",
    "ResilientOracle": "0x6c01ECa2B5C97F135406a3A5531445A7d977D28e",

Note: Need to update package version for governance-contracts once new package is released.

Checklist

  • I have updated the documentation to account for the changes in the code.
  • If I added new functionality, I added tests covering it.
  • If I fixed a bug, I added a test preventing this bug from silently reappearing again.
  • My contribution follows Venus contribution guidelines.

@Debugger022 Debugger022 self-assigned this Jul 5, 2024
@Debugger022 Debugger022 marked this pull request as draft July 5, 2024 05:42
@chechu chechu changed the title Deployments of Oracles on OpSepolia [VEN-2723]: Deployments of Oracles on OpSepolia Aug 9, 2024
@Debugger022 Debugger022 marked this pull request as ready for review August 29, 2024 13:41
chechu
chechu reviewed Sep 3, 2024
View reviewed changes
.env.example Outdated Show resolved Hide resolved
helpers/deploymentConfig.ts Outdated Show resolved Hide resolved
helpers/deploymentConfig.ts Outdated Show resolved Hide resolved
@Debugger022 Debugger022 requested a review from chechu September 4, 2024 12:29
@GitGuru7
Copy link
Contributor

GitGuru7 commented Sep 4, 2024

Add token details in config, otherwise LGTM!

chechu
chechu reviewed Sep 10, 2024
View reviewed changes
helpers/deploymentConfig.ts Outdated Show resolved Hide resolved
helpers/deploymentConfig.ts Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Code Coverage

Package Line Rate Branch Rate Health
contracts 85% 80% ✔
contracts.interfaces 28% 21% ❌
contracts.oracles 89% 80% ✔
contracts.oracles.common 100% 100% ✔
Summary 84% (288 / 342) 76% (142 / 188) ✔

@Debugger022 Debugger022 requested a review from chechu September 11, 2024 09:33
@Debugger022 Debugger022 merged commit bc05014 into develop Sep 12, 2024
4 checks passed
@chechu chechu mentioned this pull request Oct 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chechu chechu chechu approved these changes

@web3rover web3rover Awaiting requested review from web3rover

@GitGuru7 GitGuru7 Awaiting requested review from GitGuru7

Assignees

@Debugger022 Debugger022

Labels
OP sepolia
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Debugger022 @GitGuru7 @chechu