[VEN-2676] ezETH Oracle Deployment #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chechu
reviewed
Jul 23, 2024
| @@ -115,6 +115,8 @@ export const ADDRESSES: PreconfiguredAddresses = { | |||
| PTweETH_26DEC2024: "0x56107201d3e4b7Db92dEa0Edb9e0454346AEb8B5", | |||
| FRAX: "0x10630d59848547c9F59538E2d8963D63B912C075", | |||
| sfrxETH: "0x14AECeEc177085fd09EA07348B4E1F7Fcc030fA1", | |||
| rsETH: "0xfA0614E5C803E15070d31f7C38d2d430EBe68E47", | |||
There was a problem hiding this comment.
Wouldn't it be better to add these addresses only to the deployment scripts that use them?
There was a problem hiding this comment.
Right now we are following the practice of keeping the addresses in this config file for all the scripts. This seems to be a cleaner approach. Otherwise I don't see a big difference.
chechu
approved these changes
Jul 26, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves VEN-2676
Checklist