Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VEN-2953] Deploy Oracles to Base Mainnet #238

Merged
merged 10 commits into from
Dec 12, 2024
Merged

[VEN-2953] Deploy Oracles to Base Mainnet #238

merged 10 commits into from
Dec 12, 2024

Conversation

web3rover
Copy link
Contributor

Description

Resolves #

Checklist

  • I have updated the documentation to account for the changes in the code.
  • If I added new functionality, I added tests covering it.
  • If I fixed a bug, I added a test preventing this bug from silently reappearing again.
  • My contribution follows Venus contribution guidelines.

@web3rover web3rover self-assigned this Dec 3, 2024
@web3rover web3rover requested review from chechu and GitGuru7 December 3, 2024 09:13
@chechu chechu changed the title [VEN-2874] Deploy Oracles to Base Mainnet [VEN-2953] Deploy Oracles to Base Mainnet Dec 5, 2024
chechu
chechu reviewed Dec 5, 2024
View reviewed changes
.env.example Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2024

Code Coverage

Package Line Rate Branch Rate Health
contracts 85% 80% ✔
contracts.interfaces 28% 21% ❌
contracts.oracles 88% 80% ✔
contracts.oracles.common 100% 100% ✔
Summary 83% (288 / 345) 76% (142 / 188) ✔

@web3rover web3rover merged commit 88f8371 into develop Dec 12, 2024
4 checks passed
@web3rover web3rover deleted the feat/base-oracle-deploy branch December 12, 2024 05:58
@chechu chechu mentioned this pull request Dec 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chechu chechu chechu left review comments

@GitGuru7 GitGuru7 GitGuru7 approved these changes

@kkirka kkirka kkirka approved these changes

Assignees

@web3rover web3rover

Labels
base mainnet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@web3rover @chechu @kkirka @GitGuru7