Add transient storage to Resilient oracle

.github/workflows/cd.yaml

@@ -21,8 +21,7 @@ jobs:
           cache: "yarn"
 
       - name: Install dependencies
-        # Hack to get around failing "ethereumjs-abi The remote archive doesn't match the expected checksum" error
-        run: YARN_CHECKSUM_BEHAVIOR=update yarn
+        run: yarn
 
       - name: Build
         run: yarn build

.github/workflows/ci.yml

@@ -22,8 +22,7 @@ jobs:
           cache: "yarn"
 
       - name: Install dependencies
-        # Hack to get around failing "ethereumjs-abi The remote archive doesn't match the expected checksum" error
-        run: YARN_CHECKSUM_BEHAVIOR=update yarn
+        run: yarn
 
       - name: Compile contract types
         run: yarn hardhat compile
@@ -49,8 +48,7 @@ jobs:
           cache: "yarn"
 
       - name: Install dependencies
-        # Hack to get around failing "ethereumjs-abi The remote archive doesn't match the expected checksum" error
-        run: YARN_CHECKSUM_BEHAVIOR=update yarn
+        run: yarn
 
       - name: Run hardhat tests coverage
         run: yarn hardhat:coverage
@@ -89,8 +87,7 @@ jobs:
           cache: "yarn"
 
       - name: Install dependencies
-        # Hack to get around failing "ethereumjs-abi The remote archive doesn't match the expected checksum" error
-        run: YARN_CHECKSUM_BEHAVIOR=update yarn
+        run: yarn
 
       - name: Verify deployments work
         run: yarn hardhat deploy

contracts/ResilientOracle.sol

@@ -88,6 +88,9 @@ contract ResilientOracle is PausableUpgradeable, AccessControlledV8, ResilientOr
 
     mapping(address => TokenConfig) private tokenConfigs;
 
+    /// Slot to cache the asset's price, used for transient storage
+    bytes32 constant CACHE_SLOT = keccak256(abi.encode("venus-protocol/oracle/ResilientOracle/cache"));
+
     event TokenConfigAdded(
         address indexed asset,
         address indexed mainOracle,
@@ -233,11 +236,7 @@ contract ResilientOracle is PausableUpgradeable, AccessControlledV8, ResilientOr
      */
     function updatePrice(address vToken) external override {
         address asset = _getUnderlyingAsset(vToken);
-        (address pivotOracle, bool pivotOracleEnabled) = getOracle(asset, OracleRole.PIVOT);
-        if (pivotOracle != address(0) && pivotOracleEnabled) {
-            //if pivot oracle is not TwapOracle it will revert so we need to catch the revert
-            try TwapInterface(pivotOracle).updateTwap(asset) {} catch {}
-        }
+        _updateAssetPrice(asset);
     }
 
     /**
@@ -246,11 +245,7 @@ contract ResilientOracle is PausableUpgradeable, AccessControlledV8, ResilientOr
      * @param asset asset address
      */
     function updateAssetPrice(address asset) external {
-        (address pivotOracle, bool pivotOracleEnabled) = getOracle(asset, OracleRole.PIVOT);
-        if (pivotOracle != address(0) && pivotOracleEnabled) {
-            //if pivot oracle is not TwapOracle it will revert so we need to catch the revert
-            try TwapInterface(pivotOracle).updateTwap(asset) {} catch {}
-        }
+        _updateAssetPrice(asset);
     }
 
     /**
@@ -329,6 +324,50 @@ contract ResilientOracle is PausableUpgradeable, AccessControlledV8, ResilientOr
         enabled = tokenConfigs[asset].enableFlagsForOracles[uint256(role)];
     }
 
+    /**
+     * @notice Updates the pivot oracle price. Currently using TWAP
+     * @dev Cache the asset price and return if already cached
+     * @param asset asset address
+     */
+    function _updateAssetPrice(address asset) internal {
+        if (_readCachedPrice(asset) != 0) {
+            return;
+        }
+
+        (address pivotOracle, bool pivotOracleEnabled) = getOracle(asset, OracleRole.PIVOT);
+        if (pivotOracle != address(0) && pivotOracleEnabled) {
+            //if pivot oracle is not TwapOracle it will revert so we need to catch the revert
+            try TwapInterface(pivotOracle).updateTwap(asset) {} catch {}
+        }
+
+        uint256 price = _getPrice(asset);
+        _cachePrice(asset, price);
+    }
+
+    /**
+     * @notice Cache the asset price into transient storage
+     * @param key address of the asset
+     * @param value asset price
+     */
+    function _cachePrice(address key, uint256 value) internal {
+        bytes32 slot = keccak256(abi.encode(CACHE_SLOT, key));
+        assembly ("memory-safe") {
+            tstore(slot, value)
+        }
+    }
+
+    /**
+     * @notice Read cached price from transient storage
+     * @param key address of the asset
+     * @return value cached asset price
+     */
+    function _readCachedPrice(address key) internal view returns (uint256 value) {
+        bytes32 slot = keccak256(abi.encode(CACHE_SLOT, key));
+        assembly ("memory-safe") {
+            value := tload(slot)
+        }
+    }
+
     function _getPrice(address asset) internal view returns (uint256) {
         uint256 pivotPrice = INVALID_PRICE;
 

hardhat.config.ts

@@ -63,7 +63,7 @@ const config: HardhatUserConfig = {
               yul: !process.env.CI,
             },
           },
-          evmVersion: "paris",
+          evmVersion: "cancun",
           outputSelection: {
             "*": {
               "*": ["storageLayout"],

hardhat.config.zksync.ts

@@ -77,7 +77,7 @@ const config: HardhatUserConfig = {
               yul: !process.env.CI,
             },
           },
-          evmVersion: "paris",
+          evmVersion: "cancun",
           outputSelection: {
             "*": {
               "*": ["storageLayout"],

package.json

@@ -35,15 +35,15 @@
   },
   "dependencies": {
     "@chainlink/contracts": "^0.5.1",
-    "@defi-wonderland/smock": "2.3.5",
+    "@defi-wonderland/smock": "2.4.0",
     "@nomicfoundation/hardhat-network-helpers": "^1.0.8",
     "@openzeppelin/contracts": "^4.6.0",
     "@openzeppelin/contracts-upgradeable": "^4.7.3",
     "@venusprotocol/governance-contracts": "^2.4.0",
     "@venusprotocol/solidity-utilities": "^2.0.0",
     "@venusprotocol/venus-protocol": "^9.1.0",
     "ethers": "^5.6.8",
-    "hardhat": "2.19.5",
+    "hardhat": "2.22.15",
     "hardhat-deploy": "^0.12.4",
     "module-alias": "^2.2.2",
     "solidity-docgen": "^0.6.0-beta.29"
@@ -117,5 +117,9 @@
   },
   "_moduleAliases": {
     "@nomiclabs/hardhat-ethers": "node_modules/hardhat-deploy-ethers"
+  },
+  "resolutions": {
+    "hardhat": "2.22.15",
+    "@defi-wonderland/smock": "2.4.0"
   }
 }