[VEN-2943]: add support for Pendle's getPtToSyRate #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkirka
changed the title
kkirka
force-pushed
the
feat/pendle-sy-rate
branch
from
de5f34f to
97d3797
Compare
|
chechu
changed the title
GitGuru7
reviewed
Dec 12, 2024
| address market, | ||
| uint32 duration | ||
| address /* market */, | ||
| uint32 /* duration */ |
There was a problem hiding this comment.
Why we have commented the args? Can't we remove them?
There was a problem hiding this comment.
Solidity compiler complains when names are present but unused. I commented them out to silence the warnings while preserving the readability. We can remove them for sure if you think it's better, I'm ok with either.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies Pendle oracle to support using yield tokens as a base, as an alternative to using the underlying asset directly. This is the approach recommended by the Pendle team for tokens where redemptions/withdrawals are not guaranteed.