Skip to content

[VEN-2608]: TimeManagerV5 storage fix #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 16, 2024
Merged

[VEN-2608]: TimeManagerV5 storage fix #28

merged 1 commit into from
May 16, 2024

Conversation

Debugger022
Copy link
Contributor

Description

Resolves #VEN-2608
This PR fixes the size of deprecatedSlot in TimeManagerV5 from bytes32 to bytes8 following old storage.

Checklist

  • I have updated the documentation to account for the changes in the code.
  • If I added new functionality, I added tests covering it.
  • If I fixed a bug, I added a test preventing this bug from silently reappearing again.
  • My contribution follows Venus contribution guidelines.

@Debugger022 Debugger022 requested review from chechu and web3rover May 16, 2024 07:43
@Debugger022 Debugger022 self-assigned this May 16, 2024
@github-actions GitHub Actions
Copy link

Code Coverage

Package Line Rate Branch Rate Health
contracts 24% 30% ❌
Summary 24% (15 / 62) 30% (9 / 30) ❌

@chechu chechu merged commit 797b19d into develop May 16, 2024
@chechu chechu mentioned this pull request May 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chechu chechu chechu approved these changes

@web3rover web3rover Awaiting requested review from web3rover

Assignees

@Debugger022 Debugger022

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Debugger022 @chechu