Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VEN-2258]: add TimeManagerV5 and TimeManagerV8 #8

Merged
merged 5 commits into from
Dec 21, 2023
Merged

[VEN-2258]: add TimeManagerV5 and TimeManagerV8 #8

merged 5 commits into from
Dec 21, 2023

Conversation

GitGuru7
Copy link
Contributor

@GitGuru7 GitGuru7 commented Dec 19, 2023 •
edited
Loading

Description

This PR contains 2 contracts TimeMangerV5 and TimeManagerV8

  • TimeManagerV5 is compatible with solidity version 0.5.16.
  • TimeManagerV8 is compatible with solidity version 0.8.13.
  • Tested TimeManagerV5 functionalities.

Resolves VEN-2258

Checklist

  • I have updated the documentation to account for the changes in the code.
  • If I added new functionality, I added tests covering it.
  • If I fixed a bug, I added a test preventing this bug from silently reappearing again.
  • My contribution follows Venus contribution guidelines.

@GitGuru7 GitGuru7 self-assigned this Dec 19, 2023
@GitGuru7 GitGuru7 requested a review from chechu December 19, 2023 13:41
@GitGuru7 GitGuru7 requested a review from Debugger022 December 20, 2023 10:53
@github-actions GitHub Actions
Copy link

Code Coverage

Package Line Rate Branch Rate Health
contracts 24% 31% ❌
Summary 24% (14 / 59) 31% (8 / 26) ❌

@GitGuru7 GitGuru7 merged commit df3bce3 into develop Dec 21, 2023
3 checks passed
@chechu chechu mentioned this pull request Dec 27, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chechu chechu chechu approved these changes

@Debugger022 Debugger022 Debugger022 approved these changes

Assignees

@GitGuru7 GitGuru7

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GitGuru7 @chechu @Debugger022