Add tests mantissa refactor #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coreyar
force-pushed
the
add-tests-mantissa-refactor
branch
from
629ad18 to
81c0fc6
Compare
coreyar
force-pushed
the
add-tests-mantissa-refactor
branch
5 times, most recently
from
f6cf26b to
669efc9
Compare
coreyar
force-pushed
the
add-tests-mantissa-refactor
branch
from
669efc9 to
26bbd10
Compare
coreyar
force-pushed
the
add-tests-mantissa-refactor
branch
from
26bbd10 to
bf53351
Compare
gleiser-oliveira
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before updating the Venus Core subgraph I added tests. I used the Isolated Pool tests as a base and updated the handlers and graph keys to pass the tests.
This PR also changes how we use the vTokenDecimal. It is not assumed to be 8 but rather fetched from the contract.
This change and correcting some values labeled as mantissa but are actually scaled down will need to be brought to the isolated pools subgraph