Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VEN-2271]: add tests to increase coverage #14

Merged
merged 5 commits into from
Jan 9, 2024
Merged

[VEN-2271]: add tests to increase coverage #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a9eee78
refactor: increased test coverage
GitGuru7 Dec 28, 2023
26e3feb
Merge branch 'develop' into feat/VEN-2271
GitGuru7 Dec 28, 2023
c8d7365
fix: remove redundant code
GitGuru7 Dec 28, 2023
c1ecdaa
fix: resolve comments
GitGuru7 Jan 8, 2024
1969bd5
Merge branch 'develop' into feat/VEN-2271
GitGuru7 Jan 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
73 changes: 51 additions & 22 deletions test/bridgeAdmin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,29 @@ describe("Bridge Admin: ", function () {
const singleTransactionLimit = convertToUnit(10, 18);
const maxDailyTransactionLimit = convertToUnit(100, 18);

const functionregistry = [
chechu marked this conversation as resolved.
Show resolved Hide resolved
"setOracle(address)",
"setMaxSingleTransactionLimit(uint16,uint256)",
"setMaxDailyLimit(uint16,uint256)",
"setMaxSingleReceiveTransactionLimit(uint16,uint256)",
"setMaxDailyReceiveLimit(uint16,uint256)",
"pause()",
"unpause()",
"setWhitelist(address,bool)",
"setConfig(uint16,uint16,uint256,bytes)",
"setSendVersion(uint16)",
"setReceiveVersion(uint16)",
"forceResumeReceive(uint16,bytes)",
"setTrustedRemoteAddress(uint16,bytes)",
"setPrecrime(address)",
"setMinDstGas(uint16,uint16,uint256)",
"setPayloadSizeLimit(uint16,uint256)",
"removeTrustedRemote(uint16)",
"updateSendAndCallEnabled(bool)",
"sweepToken(address,address,uint256)",
"dropFailedMessage(uint16,bytes,uint64)",
];

let LZEndpointMock: LZEndpointMock__factory,
ProxyOFTV2Dest: XVSProxyOFTDest__factory,
RemoteTokenFactory: XVS__factory,
Expand Down Expand Up @@ -84,39 +107,46 @@ describe("Bridge Admin: ", function () {
await remoteOFT.transferOwnership(bridgeAdmin.address);

remotePath = ethers.utils.solidityPack(["address", "address"], [AddressOne, remoteOFT.address]);
const functionregistry = [
"setOracle(address)",
"setMaxSingleTransactionLimit(uint16,uint256)",
"setMaxDailyLimit(uint16,uint256)",
"setMaxSingleReceiveTransactionLimit(uint16,uint256)",
"setMaxDailyReceiveLimit(uint16,uint256)",
"pause()",
"unpause()",
"setWhitelist(address,bool)",
"setConfig(uint16,uint16,uint256,bytes)",
"setSendVersion(uint16)",
"setReceiveVersion(uint16)",
"forceResumeReceive(uint16,bytes)",
"setTrustedRemote(uint16,bytes)",
"setTrustedRemoteAddress(uint16,bytes)",
"setPrecrime(address)",
"setMinDstGas(uint16,uint16,uint256)",
"setPayloadSizeLimit(uint16,uint256)",
"setUseCustomAdapterParams(bool)",
];

const activeArray = new Array(functionregistry.length).fill(true);
await bridgeAdmin.upsertSignature(functionregistry, activeArray);
await loadFixture(grantPermissionsFixture);
});

it("Revert when inputs length mismatch in function registry", async function () {
const activeArray = new Array(functionregistry.length - 1).fill(true);

await expect(bridgeAdmin.upsertSignature(functionregistry, activeArray)).to.be.revertedWith(
"Input arrays must have the same length",
);
});

it("Deletes from function registry", async function () {
const activeArray = new Array(functionregistry.length).fill(true);
await bridgeAdmin.upsertSignature(functionregistry, activeArray);
await bridgeAdmin.upsertSignature(["fakeFunction(uint256)"], [true]);
await expect(bridgeAdmin.upsertSignature(["fakeFunction(uint256)"], [false])).to.emit(
bridgeAdmin,
"FunctionRegistryChanged",
);
});

it("Reverts when non owner calls upsert signature", async function () {
const activeArray = new Array(functionregistry.length - 1).fill(true);

await expect(bridgeAdmin.connect(acc2).upsertSignature(functionregistry, activeArray)).to.be.revertedWith(
"Ownable: caller is not the owner",
);
});

it("Revert if EOA called owner function of bridge", async function () {
await expect(remoteOFT.connect(acc1).setTrustedRemote(localChainId, remotePath)).to.be.revertedWith(
"Ownable: caller is not the owner",
);
});

it("Revert if permissions are not granted to call owner functions of bridge", async function () {
let data = remoteOFT.interface.encodeFunctionData("setTrustedRemote", [localChainId, remotePath]);
let data = remoteOFT.interface.encodeFunctionData("setTrustedRemoteAddress", [localChainId, remotePath]);
await expect(
acc1.sendTransaction({
to: bridgeAdmin.address,
Expand Down Expand Up @@ -162,7 +192,6 @@ describe("Bridge Admin: ", function () {
}),
).to.revertedWithCustomError(bridgeAdmin, "Unauthorized");
});

it("Success if permissions are granted to call owner functions of bridge", async function () {
let data = remoteOFT.interface.encodeFunctionData("setMaxDailyLimit", [localChainId, maxDailyTransactionLimit]);
await acc2.sendTransaction({
Expand Down
Loading
Loading