Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VEN-2208]: deployments of token bridge on opBNBMainnet #16

Merged
merged 5 commits into from
Feb 7, 2024
Merged

[VEN-2208]: deployments of token bridge on opBNBMainnet #16

merged 5 commits into from
Feb 7, 2024

Conversation

GitGuru7
Copy link
Collaborator

Resolves VEN-2208

Checklist

  • I have updated the documentation to account for the changes in the code.
  • If I added new functionality, I added tests covering it.
  • If I fixed a bug, I added a test preventing this bug from silently reappearing again.
  • My contribution follows Venus contribution guidelines.

@GitGuru7 GitGuru7 requested a review from chechu December 29, 2023 11:12
@GitGuru7 GitGuru7 self-assigned this Dec 29, 2023
@chechu chechu added the opBNB label Dec 29, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2024

Code Coverage

Package Line Rate Branch Rate Health
Bridge 79% 50% ➖
Bridge.interfaces 100% 100% ✔
Bridge.token 61% 58% ➖
Summary 74% (176 / 237) 52% (68 / 132) ➖

@chechu chechu requested a review from 0xlucian January 15, 2024 00:16
chechu
chechu reviewed Jan 15, 2024
View reviewed changes
Copy link
Member

@chechu chechu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's wait for having the contracts verified at opbnbscan

@GitGuru7 GitGuru7 merged commit bac4de8 into develop Feb 7, 2024
@chechu chechu mentioned this pull request Feb 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chechu chechu chechu approved these changes

@0xlucian 0xlucian Awaiting requested review from 0xlucian

Assignees

@GitGuru7 GitGuru7

Labels
opBNB
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GitGuru7 @chechu