Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VEN-2954] [VEN-2955] Deploy XVS and XVS Bridge on Base Mainnet #45

Merged
merged 13 commits into from
Dec 15, 2024
Merged

[VEN-2954] [VEN-2955] Deploy XVS and XVS Bridge on Base Mainnet #45

merged 13 commits into from
Dec 15, 2024

Conversation

web3rover
Copy link
Contributor

Description

Resolves #

Checklist

  • I have updated the documentation to account for the changes in the code.
  • If I added new functionality, I added tests covering it.
  • If I fixed a bug, I added a test preventing this bug from silently reappearing again.
  • My contribution follows Venus contribution guidelines.

@web3rover web3rover requested review from chechu and GitGuru7 December 4, 2024 08:52
@web3rover web3rover self-assigned this Dec 4, 2024
@web3rover web3rover marked this pull request as ready for review December 4, 2024 08:52
@chechu chechu changed the title [VEN-2875] [VEN-2877] Deploy XVS and XVS Bridge on Base Mainnet [VEN-2954] [VEN-2955] Deploy XVS and XVS Bridge on Base Mainnet Dec 5, 2024
chechu
chechu reviewed Dec 5, 2024
View reviewed changes
.env.example Outdated Show resolved Hide resolved
@web3rover @chechu
fix: fix node URL placeholder
feaf5d9 
Co-authored-by: Jesus Lanchas <[email protected]>
chechu
chechu previously approved these changes Dec 6, 2024
View reviewed changes
GitGuru7
GitGuru7 reviewed Dec 10, 2024
View reviewed changes
hardhat.config.ts Outdated Show resolved Hide resolved
GitGuru7
GitGuru7 previously approved these changes Dec 10, 2024
View reviewed changes
kkirka
kkirka reviewed Dec 10, 2024
View reviewed changes
hardhat.config.ts Outdated Show resolved Hide resolved
@chechu chechu dismissed stale reviews from GitGuru7 and themself via 9c8e6a7 December 12, 2024 15:55
@github-actions GitHub Actions
Copy link

Code Coverage

Package Line Rate Branch Rate Health
Bridge 94% 85% ✔
Bridge.interfaces 100% 100% ✔
Bridge.token 97% 83% ✔
Summary 95% (225 / 237) 85% (112 / 132) ✔

@web3rover web3rover merged commit b39731a into develop Dec 15, 2024
4 checks passed
@web3rover web3rover deleted the feat/base-deploy branch December 15, 2024 11:07
@chechu chechu mentioned this pull request Dec 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkirka kkirka kkirka left review comments

@GitGuru7 GitGuru7 GitGuru7 approved these changes

@chechu chechu chechu approved these changes

Assignees

@web3rover web3rover

Labels
base mainnet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@web3rover @chechu @kkirka @GitGuru7