Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VEN-2243]: override sendAndCall function and introduce sendAndCallEnabled with its setter #9

Merged
merged 3 commits into from
Dec 20, 2023
Merged

[VEN-2243]: override sendAndCall function and introduce sendAndCallEnabled with its setter #9

merged 3 commits into from
Dec 20, 2023

Conversation

GitGuru7
Copy link
Collaborator

@GitGuru7 GitGuru7 commented Dec 14, 2023 •
edited
Loading

Description

Resolves #VEN-2243

Checklist

  • I have updated the documentation to account for the changes in the code.
  • If I added new functionality, I added tests covering it.
  • If I fixed a bug, I added a test preventing this bug from silently reappearing again.
  • My contribution follows Venus contribution guidelines.

@GitGuru7 GitGuru7 self-assigned this Dec 14, 2023
@GitGuru7 GitGuru7 requested review from chechu and 0xlucian December 14, 2023 12:21
chechu
chechu previously approved these changes Dec 19, 2023
View reviewed changes
@github-actions GitHub Actions
Copy link

Code Coverage

Package Line Rate Branch Rate Health
Bridge 82% 52% ✔
Bridge.interfaces 100% 100% ✔
Bridge.token 84% 72% ✔
Summary 83% (171 / 207) 55% (66 / 120) ✔

@GitGuru7 GitGuru7 merged commit a1e8cd5 into develop Dec 20, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chechu chechu chechu approved these changes

@0xlucian 0xlucian Awaiting requested review from 0xlucian

Assignees

@GitGuru7 GitGuru7

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GitGuru7 @chechu