Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: increase precision of reserve and collateral factors #3586

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

therealemjy
Copy link
Member

Changes

  • use 6 decimal points in returned value of convertFactorFromSmartContract utility function

Copy link

changeset-bot bot commented Dec 2, 2024

🦋 Changeset detected

Latest commit: 74ad973

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@venusprotocol/evm Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
app-alt.venus.io 🛑 Canceled (Inspect) Dec 2, 2024 5:57pm
dapp-preview ✅ Ready (Inspect) Visit Preview Dec 2, 2024 5:57pm
dapp-testnet 🛑 Canceled (Inspect) Dec 2, 2024 5:57pm
venus.io ✅ Ready (Inspect) Visit Preview Dec 2, 2024 5:57pm

Copy link
Contributor

github-actions bot commented Dec 2, 2024

Coverage Report for ./apps/evm

Status Category Percentage Covered / Total
🔵 Lines 83.06% 43741 / 52659
🔵 Statements 83.06% 43741 / 52659
🔵 Functions 72.87% 959 / 1316
🔵 Branches 88.36% 6001 / 6791
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
apps/evm/src/utilities/convertFactorFromSmartContract.ts 100% 100% 100% 100%
Generated in workflow #9538 for commit 74ad973 by the Vitest Coverage Report Action

@therealemjy therealemjy merged commit fe719a3 into main Dec 2, 2024
9 checks passed
@therealemjy therealemjy deleted the refactor/factor-dp branch December 2, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants