Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: include generated subgraph types #3627

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

therealemjy
Copy link
Member

@therealemjy therealemjy commented Dec 11, 2024

This PR has an enormous amount of additions because it adds all the generated subgraph types files into the repository. The reasoning behind this is to make sure that every version of the dApp includes the correct subgraph types, according to its codegen config.
I've added README files for the evm and landing apps so that it is made clear that these files should not be updated manually, but only through the appropriate scripts (e.g.: yarn generate-subgraph-types in the evm app).

Changes

  • remove VITE_CODEGEN_UNRESTRICTED_THE_GRAPH_API_KEY and VITE_CODEGEN_UNRESTRICTED_NODE_REAL_API_KEY environment variables. These are no longer needed since they were used
  • add README files to the evm and landing apps
  • remove generate-subgraph-types command from root generate package script
  • include generated directories containing subgraph types
  • exclude generated directories from tests
  • exclude generated directories from linting

Copy link

changeset-bot bot commented Dec 11, 2024

🦋 Changeset detected

Latest commit: 3d63e69

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@venusprotocol/landing Minor
@venusprotocol/evm Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
app-alt.venus.io ✅ Ready (Inspect) Visit Preview Dec 18, 2024 8:53am
dapp-preview ✅ Ready (Inspect) Visit Preview Dec 18, 2024 8:53am
dapp-testnet ✅ Ready (Inspect) Visit Preview Dec 18, 2024 8:53am
venus.io ✅ Ready (Inspect) Visit Preview Dec 18, 2024 8:53am

Copy link
Contributor

github-actions bot commented Dec 11, 2024

Coverage Report for ./apps/evm

Status Category Percentage Covered / Total
🔵 Lines 82.03% 40986 / 49963
🔵 Statements 82.03% 40986 / 49963
🔵 Functions 73% 971 / 1330
🔵 Branches 89.15% 6188 / 6941
File CoverageNo changed files found.
Generated in workflow #9682 for commit 3d63e69 by the Vitest Coverage Report Action

@therealemjy therealemjy force-pushed the refactor/include-generated-files branch from eedae10 to 419229e Compare December 11, 2024 18:40
@therealemjy therealemjy force-pushed the refactor/include-generated-files branch from 419229e to d24a74b Compare December 12, 2024 10:28
@therealemjy therealemjy removed the request for review from gleiser-oliveira December 12, 2024 13:46
@therealemjy therealemjy marked this pull request as draft December 12, 2024 13:46
@therealemjy therealemjy force-pushed the refactor/include-generated-files branch from d24a74b to 92c88be Compare December 13, 2024 08:26
@therealemjy therealemjy force-pushed the refactor/include-generated-files branch from 92c88be to 2f34e42 Compare December 13, 2024 16:00
@therealemjy therealemjy merged commit e973a1b into main Dec 18, 2024
9 checks passed
@therealemjy therealemjy deleted the refactor/include-generated-files branch December 18, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants