Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update how borrow cap is displayed on Market page #3642

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

therealemjy
Copy link
Member

@therealemjy therealemjy commented Dec 17, 2024

Jira ticket(s)

VEN-2971

Changes

  • update how the borrow cap is displayed on the Market page. If the supply balance is smaller than the borrow cap, then the former is used to determine how close a market is to the threshold

Copy link

changeset-bot bot commented Dec 17, 2024

🦋 Changeset detected

Latest commit: e8e09fb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@venusprotocol/evm Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
app-alt.venus.io ✅ Ready (Inspect) Visit Preview Dec 17, 2024 2:07pm
dapp-preview ✅ Ready (Inspect) Visit Preview Dec 17, 2024 2:07pm
dapp-testnet ✅ Ready (Inspect) Visit Preview Dec 17, 2024 2:07pm
venus.io ✅ Ready (Inspect) Visit Preview Dec 17, 2024 2:07pm

Copy link
Contributor

Coverage Report for ./apps/evm

Status Category Percentage Covered / Total
🔵 Lines 83% 44992 / 54203
🔵 Statements 83% 44992 / 54203
🔵 Functions 73.02% 991 / 1357
🔵 Branches 88.95% 6285 / 7065
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
apps/evm/src/pages/Market/Page/MarketHistory/Card/index.tsx 97.88% 89.28% 50% 97.88% 82-83, 87
apps/evm/src/pages/Market/Page/MarketHistory/Card/CapThreshold/index.tsx 99.18% 66.66% 100% 99.18% 83
Generated in workflow #9677 for commit e8e09fb by the Vitest Coverage Report Action

@therealemjy therealemjy merged commit d028c27 into main Dec 17, 2024
9 checks passed
@therealemjy therealemjy deleted the feat/borrow-cap-display branch December 17, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants