Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: persisting of user settings #3657

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Conversation

therealemjy
Copy link
Member

Changes

  • update how user settings are saved and persisted so that if the local storage has been corrupted or if the structure of user settings has been updated, the dApp can keep functioning (by merging the current settings with the default ones)

Copy link

changeset-bot bot commented Dec 20, 2024

🦋 Changeset detected

Latest commit: 6b1a2e8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@venusprotocol/evm Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
app-alt.venus.io ✅ Ready (Inspect) Visit Preview Dec 20, 2024 6:07pm
dapp-preview ✅ Ready (Inspect) Visit Preview Dec 20, 2024 6:07pm
dapp-testnet ✅ Ready (Inspect) Visit Preview Dec 20, 2024 6:07pm
venus.io ✅ Ready (Inspect) Visit Preview Dec 20, 2024 6:07pm

@therealemjy therealemjy force-pushed the fix/persisted-user-settings branch from 63b89d7 to 6b1a2e8 Compare December 20, 2024 17:27
Copy link
Contributor

Coverage Report for ./apps/evm

Status Category Percentage Covered / Total
🔵 Lines 81.99% 41052 / 50066
🔵 Statements 81.99% 41052 / 50066
🔵 Functions 73.02% 972 / 1331
🔵 Branches 89.15% 6188 / 6941
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
apps/evm/src/containers/Layout/Header/TopBar/ChainSelect/index.tsx 100% 87.5% 100% 100%
apps/evm/src/containers/Layout/Header/TopBar/GaslessStatus/index.tsx 46.66% 14.28% 100% 46.66% 36-42, 51-75
apps/evm/src/containers/Layout/Header/TopBar/MdUpControls/index.tsx 0% 0% 0% 0% 1-39
apps/evm/src/hooks/useSendTransaction/index.ts 95.23% 86.66% 60% 95.23% 109, 136-137
apps/evm/src/hooks/useSendTransaction/__tests__/index.gaslessTransactions.spec.tsx 100% 100% 100% 100%
apps/evm/src/pages/Account/Settings/index.tsx 0% 0% 0% 0% 1-50
apps/evm/src/store/index.ts 100% 100% 100% 100%
Generated in workflow #9701 for commit 6b1a2e8 by the Vitest Coverage Report Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants