fix: resolve comments

VenusProtocol · Mar 21, 2023 · 4711bc4 · 4711bc4
1 parent 50f7cad
commit 4711bc4
Show file tree

Hide file tree

Showing 17 changed files with 16,928 additions and 7,239 deletions.
diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md
@@ -3,15 +3,3 @@
 <!-- Describe your changes here -->
 
 Resolves #<!-- issue id -->
-
-## Checklist
-
-<!--
-  Any non-WIP PR should have all the checkmarks set.
-  If a checkmark is not applicable to your PR, mark it as done
--->
-
-- [ ] I have updated the documentation to account for the changes in the code.
-- [ ] If I added new functionality, I added tests covering it.
-- [ ] If I fixed a bug, I added a test preventing this bug from silently reappearing again.
-- [ ] My contribution follows [Venus contribution guidelines](docs/CONTRIBUTING.md).
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -39,7 +39,7 @@ jobs:
     env:
       NODE_OPTIONS: --max-old-space-size=4096
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
 
       - uses: actions/setup-node@v2
         with:
@@ -54,5 +54,4 @@ jobs:
 
       - name: Run hardhat compile and tests coverage
         run: |
-          source .env.example
           yarn hardhat compile && yarn hardhat coverage
diff --git a/.github/workflows/create.yml b/.github/workflows/create.yml
diff --git a/.solcover.js b/.solcover.js
diff --git a/.solhint.json b/.solhint.json
diff --git a/hardhat.config.ts b/hardhat.config.ts
@@ -26,7 +26,8 @@ task("run-script", "Runs a hardhard script by name")
       console.log("Make sure you pass an existing script path. Available scripts:");
       fs.readdirSync("./script/hardhat", { withFileTypes: true }).forEach((file: fs.Dirent) => {
         // Some directories don't contain files that can be run this way
-        if (file.isDirectory() && file.name !== "simulations" && file.name !== "utils" && file.name !== "vips") {
+        const excludeDirs = ["simulations", "utils", "vips"];
+        if (file.isDirectory() && !excludeDirs.includes(file.name)) {
           console.log(`${file.name}/`);
           fs.readdirSync(`./script/hardhat/${file.name}`).forEach((file: string) => {
             console.log(`  ${file}`);
@@ -79,7 +80,7 @@ function isFork() {
         allowUnlimitedContractSize: false,
         loggingEnabled: false,
         forking: {
-          url: `https://tame-white-dinghy.bsc.discover.quiknode.pro/${process.env.QUICK_NODE_KEY}/`,
+          url: `${process.env.BSC_ARCHIVE_NODE}`,
           blockNumber: 21068448,
         },
         accounts: {