Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VEN-1146]: Added vip for comptroller diamond proxy #11

Merged
merged 25 commits into from
Sep 26, 2023

Conversation

Debugger022
Copy link
Contributor

Description

Resolves

  • VIP for the Comptroller diamond proxy(testnet).

@web3rover web3rover self-requested a review May 18, 2023 09:54
@Debugger022 Debugger022 requested review from chechu and kkirka May 18, 2023 12:01
@chechu chechu changed the title Added vip for comptroller diamond proxy [VEN-1146]: Added vip for comptroller diamond proxy May 28, 2023
@Debugger022 Debugger022 force-pushed the vip-diamond-comptroller-testnet branch from 7a7185c to cfe4633 Compare June 16, 2023 12:34
@Debugger022
Copy link
Contributor Author

Changes in this commit are pushed due to the changes in this commit

Copy link
Contributor

@kkirka kkirka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the upgrade is quite thoroughly tested. With storage layout and mint/borrow/repay/redeem tests I'm quite confident the upgrade will go smoothly <3

vips/vip-Diamond-comptroller-testnet.ts Outdated Show resolved Hide resolved
simulations/vip-diamond-comptroller-testnet/simulations.ts Outdated Show resolved Hide resolved
simulations/vip-diamond-comptroller-testnet/simulations.ts Outdated Show resolved Hide resolved
@Debugger022 Debugger022 requested a review from kkirka September 18, 2023 09:41
@Debugger022 Debugger022 force-pushed the vip-diamond-comptroller-testnet branch from 1612718 to 2c2f244 Compare September 21, 2023 14:28
@chechu chechu force-pushed the vip-diamond-comptroller-testnet branch from 2402cbf to 2b19173 Compare September 25, 2023 10:53
@chechu
Copy link
Member

chechu commented Sep 25, 2023

@Debugger022 Debugger022 merged commit 8ec9186 into develop Sep 26, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants