-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VEN-1146]: Added vip for comptroller diamond proxy #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xlucian
approved these changes
Apr 21, 2023
web3rover
approved these changes
May 18, 2023
chechu
changed the title
Added vip for comptroller diamond proxy
[VEN-1146]: Added vip for comptroller diamond proxy
May 28, 2023
chechu
reviewed
Jun 7, 2023
Debugger022
force-pushed
the
vip-diamond-comptroller-testnet
branch
from
June 16, 2023 12:34
7a7185c
to
cfe4633
Compare
Changes in this commit are pushed due to the changes in this commit |
kkirka
reviewed
Sep 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, the upgrade is quite thoroughly tested. With storage layout and mint/borrow/repay/redeem tests I'm quite confident the upgrade will go smoothly <3
GitGuru7
approved these changes
Sep 18, 2023
chechu
reviewed
Sep 19, 2023
simulations/vip-diamond-comptroller/vip-diamond-comptroller/utils/cut-params.json
Outdated
Show resolved
Hide resolved
Debugger022
force-pushed
the
vip-diamond-comptroller-testnet
branch
from
September 21, 2023 14:28
1612718
to
2c2f244
Compare
chechu
approved these changes
Sep 25, 2023
chechu
force-pushed
the
vip-diamond-comptroller-testnet
branch
from
September 25, 2023 10:53
2402cbf
to
2b19173
Compare
chechu
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves