Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VEN-2937]: permission given to timelocks on zksync and optimism #431

Merged
merged 10 commits into from
Dec 10, 2024
Merged

[VEN-2937]: permission given to timelocks on zksync and optimism #431

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
f84dc21
wip: permission given to timelocks on zksync and optimism
GitGuru7 Nov 26, 2024
8b1c490
fix: block number and index
GitGuru7 Nov 28, 2024
74b8b9f
feat: add multichain commands for testnet chains
GitGuru7 Nov 28, 2024
8b1dd02
chore: update script in package.json
GitGuru7 Nov 28, 2024
d653590
fix: simulaions
GitGuru7 Nov 28, 2024
ddb40a1
feat: add permissions on mainnets
GitGuru7 Dec 2, 2024
8646911
refactor: update block number and index of ethereum
GitGuru7 Dec 4, 2024
1de5938
refactor: add more tests in simulation on BNB
GitGuru7 Dec 4, 2024
f55a7ca
refactor: set VIP number for VIP-403
kkirka Dec 6, 2024
b5cbc4b
feat: add title and description for VIP-403
kkirka Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hardhat.config.zksync.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ const config: HardhatUserConfig = {
},
zksynctestnode: {
url: process.env.ZKSYNC_ERA_LOCAL_TEST_NODE || "http://localhost:8011",
chainId: 300, // change it to 300 for zksyncsepolia
chainId: 300, // change it to 324 for zksyncmainnet
accounts: DEPLOYER_PRIVATE_KEY ? [`0x${DEPLOYER_PRIVATE_KEY}`] : [],
blockGasLimit: BLOCK_GAS_LIMIT_PER_NETWORK.zksyncsepolia,
timeout: 2000000000,
Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
"prettier:check": "prettier --check \"**/*.{js,json,md,ts,yaml,yml,sol}\"",
"docgen": "hardhat docgen",
"clean": "hardhat clean && hardhat clean --config hardhat.config.zksync.ts",
"local-test-node:zksyncmainnet": "hardhat node-zksync --fork https://mainnet.era.zksync.io --config hardhat.config.zksync.ts",
"local-test-node:zksyncsepolia": "hardhat node-zksync --fork https://sepolia.era.zksync.dev --config hardhat.config.zksync.ts"
"local-test-node:zksyncmainnet": "hardhat node-zksync --fork https://mainnet.era.zksync.io --config hardhat.config.zksync.ts --tag 0.1.0-alpha.31",
"local-test-node:zksyncsepolia": "hardhat node-zksync --fork https://sepolia.era.zksync.dev --config hardhat.config.zksync.ts --tag 0.1.0-alpha.31"
},
"dependencies": {
"@morpho-labs/gnosis-tx-builder": "^1.3.1",
Expand Down
242 changes: 242 additions & 0 deletions simulations/vip-403/abi/ACMCommandsAggregator.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,242 @@
[
{
"inputs": [
{
"internalType": "contract IAccessControlManagerV8",
"name": "_acm",
"type": "address"
}
],
"stateMutability": "nonpayable",
"type": "constructor"
},
{
"inputs": [],
"name": "EmptyPermissions",
"type": "error"
},
{
"inputs": [],
"name": "ZeroAddressNotAllowed",
"type": "error"
},
{
"anonymous": false,
"inputs": [
{
"indexed": false,
"internalType": "uint256",
"name": "index",
"type": "uint256"
}
],
"name": "GrantPermissionsAdded",
"type": "event"
},
{
"anonymous": false,
"inputs": [
{
"indexed": false,
"internalType": "uint256",
"name": "index",
"type": "uint256"
}
],
"name": "GrantPermissionsExecuted",
"type": "event"
},
{
"anonymous": false,
"inputs": [
{
"indexed": false,
"internalType": "uint256",
"name": "index",
"type": "uint256"
}
],
"name": "RevokePermissionsAdded",
"type": "event"
},
{
"anonymous": false,
"inputs": [
{
"indexed": false,
"internalType": "uint256",
"name": "index",
"type": "uint256"
}
],
"name": "RevokePermissionsExecuted",
"type": "event"
},
{
"inputs": [],
"name": "ACM",
"outputs": [
{
"internalType": "contract IAccessControlManagerV8",
"name": "",
"type": "address"
}
],
"stateMutability": "view",
"type": "function"
},
{
"inputs": [
{
"components": [
{
"internalType": "address",
"name": "contractAddress",
"type": "address"
},
{
"internalType": "string",
"name": "functionSig",
"type": "string"
},
{
"internalType": "address",
"name": "account",
"type": "address"
}
],
"internalType": "struct ACMCommandsAggregator.Permission[]",
"name": "_permissions",
"type": "tuple[]"
}
],
"name": "addGrantPermissions",
"outputs": [],
"stateMutability": "nonpayable",
"type": "function"
},
{
"inputs": [
{
"components": [
{
"internalType": "address",
"name": "contractAddress",
"type": "address"
},
{
"internalType": "string",
"name": "functionSig",
"type": "string"
},
{
"internalType": "address",
"name": "account",
"type": "address"
}
],
"internalType": "struct ACMCommandsAggregator.Permission[]",
"name": "_permissions",
"type": "tuple[]"
}
],
"name": "addRevokePermissions",
"outputs": [],
"stateMutability": "nonpayable",
"type": "function"
},
{
"inputs": [
{
"internalType": "uint256",
"name": "index",
"type": "uint256"
}
],
"name": "executeGrantPermissions",
"outputs": [],
"stateMutability": "nonpayable",
"type": "function"
},
{
"inputs": [
{
"internalType": "uint256",
"name": "index",
"type": "uint256"
}
],
"name": "executeRevokePermissions",
"outputs": [],
"stateMutability": "nonpayable",
"type": "function"
},
{
"inputs": [
{
"internalType": "uint256",
"name": "",
"type": "uint256"
},
{
"internalType": "uint256",
"name": "",
"type": "uint256"
}
],
"name": "grantPermissions",
"outputs": [
{
"internalType": "address",
"name": "contractAddress",
"type": "address"
},
{
"internalType": "string",
"name": "functionSig",
"type": "string"
},
{
"internalType": "address",
"name": "account",
"type": "address"
}
],
"stateMutability": "view",
"type": "function"
},
{
"inputs": [
{
"internalType": "uint256",
"name": "",
"type": "uint256"
},
{
"internalType": "uint256",
"name": "",
"type": "uint256"
}
],
"name": "revokePermissions",
"outputs": [
{
"internalType": "address",
"name": "contractAddress",
"type": "address"
},
{
"internalType": "string",
"name": "functionSig",
"type": "string"
},
{
"internalType": "address",
"name": "account",
"type": "address"
}
],
"stateMutability": "view",
"type": "function"
}
]
Loading
Loading