[VEN-3024][VEN-3029] Add gmETH and gmBTC markets in the Core Pool / Arbitrum, and Thena to the Core Pool / BNB Chain #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coreyar
reviewed
Jan 27, 2025
simulations/vip-433/arbitrumone.ts
Outdated
| const BLOCKS_PER_YEAR = BigNumber.from("31536000"); | ||
| const ONE_YEAR = 3600 * 24 * 365; | ||
|
|
||
| const { POOL_REGISTRY, NORMAL_TIMELOCK, RESILIENT_ORACLE, CHAINLINK_ORACLE } = NETWORK_ADDRESSES["arbitrumone"]; |
There was a problem hiding this comment.
nit: generally we use hardcoded addresses to freeze the variables used in the VIP in the event they might be affected by a package update
coreyar
reviewed
Jan 27, 2025
simulations/vip-433/arbitrumone.ts
Outdated
| before(async () => { | ||
| await setMaxStalePeriodInChainlinkOracle( | ||
| CHAINLINK_ORACLE, | ||
| "0x5979D7b546E38E414F7E9822514be443A4800529", |
There was a problem hiding this comment.
nit: Labelded addresses are nice for readability
coreyar
approved these changes
Jan 27, 2025
GitGuru7
reviewed
Jan 28, 2025
GitGuru7
reviewed
Jan 28, 2025
|
|
||
| checkIsolatedPoolsComptrollers(); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Aren't we checking converter configurations?
chechu
reviewed
Jan 28, 2025
chechu
changed the title
chechu
changed the title
chechu
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves VEN-3024 and VEN-3029