[VEN-1830]: Poc/sepolia VIP multisig tx execution #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…using gnosis multisig
chechu
changed the title
0xlucian
commented
Sep 26, 2023
| } | ||
| export const ZERO_ADDRESS = ethers.constants.AddressZero; | ||
| export const ADDRESSES: NetworkAddress = { | ||
| sepoliaContracts: { |
There was a problem hiding this comment.
Shouldn't the key be only the network name without Contracts suffix?
There was a problem hiding this comment.
Agree we can import it into other files using an alias name to prevent confusion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new way of executing a VIP through a gnosis multisig on Sepolia network. We need this since, Sepolia is still not supported in Safe Cannonical UI