[VEN-2001]: Payments to Peckshield and Code4Rena #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: Some methods, e.g. expect(tx).to.emit, expect a response object, not a receipt object, as a parameter. We can always get receipt from response by calling `await tx.wait()`, but we can't get response from receipt. Solution: Pass plain tx as an argument of callbackAfterExecution, modify expectEvents to accept TransactionResponse and wait for the receipt under the hood.
chechu
approved these changes
Sep 22, 2023
kkirka
force-pushed
the
feat/payments-2023-09-22
branch
from
1dd2307 to
810901c
Compare
chechu
approved these changes
Sep 22, 2023
kkirka
force-pushed
the
feat/payments-2023-09-22
branch
from
1af35e5 to
0dba5a2
Compare
chechu
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a simulation for "VIP-173 Payments Issuance for performed Audits". It also modifies callbackAfterExecution type a bit to simplify assertions, see commit msg for details.