Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VEN-2036]: Add cut param for venusInitialIndex to diamond proxy #80

Merged
merged 4 commits into from
Oct 5, 2023

Conversation

Debugger022
Copy link
Contributor

@Debugger022 Debugger022 commented Sep 29, 2023

Description

This PR includes VIP for adding cut param for venusInitialIndex to Market Facet for both mainnet and testnet.

Note:- As this vip is updating diamond proxy for the first time after it's implementation, therefore added additional tests to simulations to verify all storage values, setter functions and core functionalities(mint, borrow, redeem, repay) are working fine.
Also tests for pendingRewards are added, to do so have deployed venusLens with updated code on testnet

@Debugger022 Debugger022 marked this pull request as ready for review October 3, 2023 13:31
@Debugger022 Debugger022 requested review from kkirka and 0xlucian October 3, 2023 13:33
Copy link
Contributor

@0xlucian 0xlucian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chechu chechu changed the title Vip for adding cut param for venusInitialIndex to diamond proxy Add cut param for venusInitialIndex to diamond proxy Oct 4, 2023
@chechu chechu changed the title Add cut param for venusInitialIndex to diamond proxy [VEN-2036]: Add cut param for venusInitialIndex to diamond proxy Oct 5, 2023
@chechu
Copy link
Member

chechu commented Oct 5, 2023

@Debugger022 Debugger022 merged commit 8017a99 into develop Oct 5, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants