Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Field objects are allowed to be supplied without declaring blocks #37

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rudy-on-rails
Copy link

@rudy-on-rails rudy-on-rails commented Aug 20, 2020

GraphQL endpoints do not necessarily need to specify fields as arguments when a mutation or query is received. Diverse implementations on the server-side will allow for returning non-standardized data formats, such as JSON, which breaks this library.

Fixes: #31

@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2020

Codecov Report

Merging #37 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #37   +/-   ##
=========================================
  Coverage     88.55%   88.55%           
  Complexity       68       68           
=========================================
  Files            16       16           
  Lines           166      166           
  Branches         28       28           
=========================================
  Hits            147      147           
  Misses           10       10           
  Partials          9        9           
Impacted Files Coverage Δ Complexity Δ
core/src/main/kotlin/me/lazmaid/kraph/Kraph.kt 96.77% <100.00%> (ø) 14.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4f3761...fa91f3b. Read the comment docs.

@rudy-on-rails rudy-on-rails force-pushed the rudy-on-rails/allow-field-object-declarations-to-not-use-blocks branch from 95c9802 to fa91f3b Compare August 20, 2020 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request without returning parameters
2 participants