Merge pull request #348 from VeriFIT/concat-fix

Concat fix #patch
VeriFIT · Sep 27, 2023 · 5331c53 · 5331c53
2 parents f58941a + e555504
commit 5331c53
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 0 deletions.
diff --git a/src/nfa/concatenation.cc b/src/nfa/concatenation.cc
@@ -32,6 +32,7 @@ Nfa& Nfa::concatenate(const Nfa& aut) {
         return st + n;
     };
 
+    this->delta.allocate(n);
     this->delta.append(aut.delta.renumber_targets(upd_fnc));
 
     // set accepting states

diff --git a/tests/nfa/nfa-concatenation.cc b/tests/nfa/nfa-concatenation.cc
@@ -711,6 +711,25 @@ TEST_CASE("mata::nfa::concatenate() inplace") {
         CHECK(!result.is_lang_empty());
         // TODO: Add more checks.
     }
+
+    SECTION("Delta smaller than states") {
+        Nfa lhs{};
+        Nfa rhs{};
+
+        lhs.delta.add(0, 65, 5);
+        lhs.initial.insert(0);
+        lhs.initial.insert(7);
+        lhs.final.insert(5);
+        lhs.final.insert(7);
+
+        rhs.delta.add(0, 65, 7);
+        rhs.initial.insert(0);
+        rhs.final.insert(7);
+
+        Nfa result = lhs.concatenate(rhs);
+        CHECK(!result.is_lang_empty());
+    }
+
 }
 
 TEST_CASE("Concat_inplace performance", "[.profiling]") {