Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper handling of constants (true/false) #330

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Conversation

jurajsic
Copy link
Member

This PR solves #174, i.e. it adds true/false as its own operator type in intermediate automaton and also changes the parser so that constants are given as \true/\false as we agreed in #168

@jurajsic jurajsic linked an issue Sep 11, 2023 that may be closed by this pull request
@jurajsic jurajsic requested a review from tfiedor September 11, 2023 15:18
@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Patch coverage: 98.88% and project coverage change: +0.08% 🎉

Comparison is base (d85d445) 72.67% compared to head (7f27641) 72.76%.
Report is 13 commits behind head on devel.

Additional details and impacted files
@@            Coverage Diff             @@
##            devel     #330      +/-   ##
==========================================
+ Coverage   72.67%   72.76%   +0.08%     
==========================================
  Files          33       33              
  Lines        4158     4167       +9     
  Branches      958      958              
==========================================
+ Hits         3022     3032      +10     
  Misses        755      755              
+ Partials      381      380       -1     
Files Changed Coverage Δ
src/inter-aut.cc 68.28% <98.46%> (+1.13%) ⬆️
include/mata/parser/inter-aut.hh 97.29% <100.00%> (+0.32%) ⬆️
src/mintermization.cc 81.42% <100.00%> (ø)
src/parser.cc 81.61% <100.00%> (-0.53%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Adda0 Adda0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me.

@Adda0
Copy link
Collaborator

Adda0 commented Sep 12, 2023

@martinhruska If you do not want or do not have the time, you do not have to review the code. But it might be beneficial to know about the change for when you work on further parser changes.

Copy link
Member

@tfiedor tfiedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. Did you try running this on the changes from the nfa-bench repo to verify it works OK?

@jurajsic
Copy link
Member Author

OK. Did you try running this on the changes from the nfa-bench repo to verify it works OK?

It looks like it works for few I tried.

@Adda0 Adda0 removed the request for review from martinhruska September 13, 2023 10:32
@Adda0 Adda0 merged commit 2844dd4 into devel Sep 13, 2023
20 checks passed
@Adda0 Adda0 deleted the true_false-parsing branch September 13, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Constants (true/false) in FormulaNode
3 participants