Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend binding with parsing #334

Merged
merged 3 commits into from
Sep 15, 2023
Merged

Extend binding with parsing #334

merged 3 commits into from
Sep 15, 2023

Conversation

tfiedor
Copy link
Member

@tfiedor tfiedor commented Sep 15, 2023

This PR is required for our experiments, I would appreciate faster and more lenient reviews.

It simply adds from_mata fucntion for parsing single or multiple mata files.

@tfiedor tfiedor requested a review from Adda0 September 15, 2023 16:00
@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.04% ⚠️

Comparison is base (d1f1bb9) 72.74% compared to head (1f8033b) 72.70%.
Report is 1 commits behind head on devel.

❗ Current head 1f8033b differs from pull request most recent head 91fee94. Consider uploading reports for the commit 91fee94 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##            devel     #334      +/-   ##
==========================================
- Coverage   72.74%   72.70%   -0.04%     
==========================================
  Files          33       33              
  Lines        4146     4148       +2     
  Branches      953      953              
==========================================
  Hits         3016     3016              
- Misses        755      757       +2     
  Partials      375      375              
Files Changed Coverage Δ
include/mata/nfa/builder.hh 80.00% <ø> (ø)
include/mata/parser/inter-aut.hh 97.29% <0.00%> (ø)
src/nfa/builder.cc 79.84% <0.00%> (-1.26%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tfiedor
Copy link
Member Author

tfiedor commented Sep 15, 2023

Sadly, there is some issue with tests, I will solve it next week and use custom branch for experiments.

Copy link
Collaborator

@Adda0 Adda0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do not forget to fix the Python test later on.

@tfiedor tfiedor merged commit fde78f4 into devel Sep 15, 2023
18 checks passed
@tfiedor tfiedor deleted the binding-parser branch September 15, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants