Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AFA implementation #337

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Remove AFA implementation #337

merged 1 commit into from
Sep 27, 2023

Conversation

Adda0
Copy link
Collaborator

@Adda0 Adda0 commented Sep 20, 2023

This PR removes the current implementation of AFA from Mata, as agreed upon in our meetings.

The parsing of AFA .mata files into AFA intermediate format was left untouched. This can be reused for the planned new implementation of AFA. The function to construct Afa from the intermediate AFA was, however, removed.

@Adda0 Adda0 requested review from tfiedor and jurajsic September 20, 2023 06:24
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Patch coverage has no change and project coverage change: -1.40% ⚠️

Comparison is base (7f18cca) 72.93% compared to head (f7e8a86) 71.54%.
Report is 10 commits behind head on devel.

Additional details and impacted files
@@            Coverage Diff             @@
##            devel     #337      +/-   ##
==========================================
- Coverage   72.93%   71.54%   -1.40%     
==========================================
  Files          33       30       -3     
  Lines        4134     3570     -564     
  Branches      952      830     -122     
==========================================
- Hits         3015     2554     -461     
+ Misses        740      730      -10     
+ Partials      379      286      -93     

see 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Adda0 Adda0 merged commit 7831cdc into devel Sep 27, 2023
18 of 20 checks passed
@Adda0 Adda0 deleted the remove_afa branch September 27, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants