Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Rewrite opening files to fix compilation errors" #345

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

Adda0
Copy link
Collaborator

@Adda0 Adda0 commented Sep 26, 2023

This PR reverts commit 7f18cca, which for some unknown reason causes server with experiments to fail to compile.

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (3380500) 72.94% compared to head (069554c) 72.94%.
Report is 3 commits behind head on devel.

Additional details and impacted files
@@           Coverage Diff           @@
##            devel     #345   +/-   ##
=======================================
  Coverage   72.94%   72.94%           
=======================================
  Files          33       33           
  Lines        4144     4144           
  Branches      955      955           
=======================================
  Hits         3023     3023           
  Misses        740      740           
  Partials      381      381           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Adda0 Adda0 merged commit f58941a into devel Sep 26, 2023
20 checks passed
@Adda0 Adda0 deleted the revert_opening_files branch September 26, 2023 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant