Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concat problem #347

Closed
wants to merge 9 commits into from
Closed

Concat problem #347

wants to merge 9 commits into from

Conversation

kilohsakul
Copy link
Collaborator

Bug in concatenation.
Buggy example with some comment is in test-integration/src/trim.cc.

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Attention: 35 lines in your changes are missing coverage. Please review.

Comparison is base (3380500) 72.94% compared to head (ffd2fd3) 72.81%.
Report is 5 commits behind head on devel.

Additional details and impacted files
@@            Coverage Diff             @@
##            devel     #347      +/-   ##
==========================================
- Coverage   72.94%   72.81%   -0.14%     
==========================================
  Files          33       33              
  Lines        4144     4212      +68     
  Branches      955      967      +12     
==========================================
+ Hits         3023     3067      +44     
- Misses        740      761      +21     
- Partials      381      384       +3     
Files Coverage Δ
include/mata/nfa/delta.hh 90.54% <ø> (ø)
include/mata/nfa/nfa.hh 100.00% <ø> (ø)
include/mata/nfa/plumbing.hh 94.44% <100.00%> (ø)
src/nfa/inclusion.cc 90.09% <100.00%> (ø)
src/nfa/operations.cc 63.90% <100.00%> (+0.29%) ⬆️
src/strings/nfa-noodlification.cc 71.49% <66.66%> (ø)
src/nfa/delta.cc 82.71% <80.00%> (-0.08%) ⬇️
src/nfa/intersection.cc 72.64% <70.90%> (-10.43%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vhavlena
Copy link
Collaborator

This could be closed (fixed in #348 )

@Adda0
Copy link
Collaborator

Adda0 commented Sep 27, 2023

We will close this PR and create a test from tests-integration/src/trim.cc to check that the error is fixed. (Do not delete the branch for now.)

@Adda0 Adda0 closed this Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants