Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimization of antichain inclusion #364

Merged
merged 6 commits into from
Oct 7, 2023

Conversation

kilohsakul
Copy link
Collaborator

Worklist ordered by set size so small sets are processed first.

@kilohsakul kilohsakul requested a review from Adda0 October 7, 2023 11:23
@codecov
Copy link

codecov bot commented Oct 7, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (5c43024) 71.58% compared to head (ead8c28) 71.57%.
Report is 1 commits behind head on devel.

Additional details and impacted files
@@            Coverage Diff             @@
##            devel     #364      +/-   ##
==========================================
- Coverage   71.58%   71.57%   -0.01%     
==========================================
  Files          30       30              
  Lines        3604     3610       +6     
  Branches      829      830       +1     
==========================================
+ Hits         2580     2584       +4     
  Misses        735      735              
- Partials      289      291       +2     
Files Coverage Δ
src/nfa/inclusion.cc 88.78% <85.00%> (-1.32%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Adda0 Adda0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. The performance increase is significant.

src/nfa/inclusion.cc Show resolved Hide resolved
We insert to the vector using iterators which is not ideal. But it seems
to work better than deque.
@Adda0 Adda0 merged commit e75cdf6 into devel Oct 7, 2023
19 of 20 checks passed
@Adda0 Adda0 deleted the optimization-of-inclusion-antichain branch October 7, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants