Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distances in inclusion #365

Merged
merged 6 commits into from
Oct 8, 2023
Merged

Distances in inclusion #365

merged 6 commits into from
Oct 8, 2023

Conversation

kilohsakul
Copy link
Collaborator

compute ditance of states to final states and prune inclusion pairs based on that, fastetr on some problematic examples

@kilohsakul kilohsakul requested a review from Adda0 October 8, 2023 17:11
@codecov
Copy link

codecov bot commented Oct 8, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (ead8c28) 71.57% compared to head (d944cf0) 71.80%.
Report is 1 commits behind head on devel.

❗ Current head d944cf0 differs from pull request most recent head a19cec0. Consider uploading reports for the commit a19cec0 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##            devel     #365      +/-   ##
==========================================
+ Coverage   71.57%   71.80%   +0.22%     
==========================================
  Files          30       30              
  Lines        3610     3643      +33     
  Branches      830      836       +6     
==========================================
+ Hits         2584     2616      +32     
  Misses        735      735              
- Partials      291      292       +1     
Files Coverage Δ
include/mata/nfa/nfa.hh 100.00% <ø> (ø)
src/nfa/inclusion.cc 90.24% <94.73%> (+1.45%) ⬆️
src/nfa/nfa.cc 81.09% <94.11%> (+1.00%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kilohsakul
Copy link
Collaborator Author

Try these examples (problematic in the last two versions of mata)

/nfa-bench/benchmarks/automata_inclusion/true-IBakery5PUnrEnc-Rev-FbOneOne-Nondet-Partiali-B-1-lhs.mata /nfa-bench/benchmarks/automata_inclusion/true-IBakery5PUnrEnc-Rev-FbOneOne-Nondet-Partiali-B-1-rhs.mata

/nfa-bench/benchmarks/automata_inclusion/false-IBakery5PUnrEnc-FbOneOne-Nondet-Partiali-B-3-lhs.mata /nfa-bench/benchmarks/automata_inclusion/false-IBakery5PUnrEnc-FbOneOne-Nondet-Partiali-B-3-rhs.mata

/nfa-bench/benchmarks/automata_inclusion/false-IBakery5PUnrEnc-FbOneOne-Nondet-Partiali-B-1-lhs.mata /nfa-bench/benchmarks/automata_inclusion/false-IBakery5PUnrEnc-FbOneOne-Nondet-Partiali-B-1-rhs.mata

Copy link
Collaborator

@Adda0 Adda0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We will run the experiments and see how it performs.

@Adda0 Adda0 merged commit a08a3ae into devel Oct 8, 2023
@Adda0 Adda0 deleted the distances-in-inclusion branch October 8, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants