Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do I deserve to be a contributor? #367

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Conversation

vhavlena
Copy link
Collaborator

Adding myself to the list.

@Adda0
Copy link
Collaborator

Adda0 commented Oct 10, 2023

I plan to update README, documentation, mata format and licence before the artefact submission. This is one of the necessary steps.

I will merge the PR immediately, but feel free to joke around in this PR afterwards, as I am sure you are more than happy to.

@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (a19cec0) 71.80% compared to head (bdf0e49) 71.80%.
Report is 1 commits behind head on devel.

Additional details and impacted files
@@           Coverage Diff           @@
##            devel     #367   +/-   ##
=======================================
  Coverage   71.80%   71.80%           
=======================================
  Files          30       30           
  Lines        3643     3643           
  Branches      836      836           
=======================================
  Hits         2616     2616           
  Misses        735      735           
  Partials      292      292           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Adda0 Adda0 merged commit 281848f into devel Oct 10, 2023
@Adda0 Adda0 deleted the adding-the-best-contributor branch October 10, 2023 07:24
@tfiedor
Copy link
Member

tfiedor commented Oct 10, 2023

I am strongly championing for reverting this change. It leads to two warnings in libmata library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants