Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In place union and concatenation in Python binding #369

Merged
merged 2 commits into from
Nov 16, 2023

Conversation

Adda0
Copy link
Collaborator

@Adda0 Adda0 commented Oct 10, 2023

This PR adds in-place variants of concatenation and union to Python binding. Additionally, it adds a temporary deepcopy function for Python Nfa class. Proper deepcopy using Python copy.deepcopy() will come in a later PR.

@Adda0 Adda0 requested a review from tfiedor October 10, 2023 11:31
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (1494bd4) 71.80% compared to head (60954c0) 71.82%.
Report is 18 commits behind head on devel.

❗ Current head 60954c0 differs from pull request most recent head 09a43aa. Consider uploading reports for the commit 09a43aa to get more accurate results

Files Patch % Lines
src/nfa/delta.cc 81.81% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            devel     #369      +/-   ##
==========================================
+ Coverage   71.80%   71.82%   +0.01%     
==========================================
  Files          30       30              
  Lines        3643     3642       -1     
  Branches      836      834       -2     
==========================================
  Hits         2616     2616              
  Misses        735      735              
+ Partials      292      291       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Adda0 Adda0 requested review from jurajsic and removed request for tfiedor November 10, 2023 20:55
Copy link
Member

@jurajsic jurajsic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some weird sentences in comments

bindings/python/libmata/nfa/nfa.pyx Outdated Show resolved Hide resolved
bindings/python/libmata/nfa/nfa.pyx Outdated Show resolved Hide resolved
@Adda0 Adda0 force-pushed the in_place_union_concatenation_python_binding branch from 60954c0 to 09a43aa Compare November 16, 2023 18:42
@Adda0 Adda0 merged commit a57f582 into devel Nov 16, 2023
18 checks passed
@Adda0 Adda0 deleted the in_place_union_concatenation_python_binding branch November 16, 2023 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants